From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:53676)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UTA2H-0001tl-C7
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 08:03:29 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UTA2C-0004ZJ-QA
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 08:03:25 -0400
Received: from mx1.redhat.com ([209.132.183.28]:64827)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1UTA2C-0004Z6-Ip
	for qemu-devel@nongnu.org; Fri, 19 Apr 2013 08:03:20 -0400
Date: Fri, 19 Apr 2013 14:03:09 +0200
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20130419120309.GB23751@stefanha-thinkpad.redhat.com>
References: <1366187964-14265-1-git-send-email-qemulist@gmail.com>
	<1366187964-14265-7-git-send-email-qemulist@gmail.com>
	<20130418143417.GB23230@stefanha-thinkpad.redhat.com>
	<CAJnKYQnxdyn4PzLen31sFTFYUpucQK8RNiJspPp0pH91WJD2xQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJnKYQnxdyn4PzLen31sFTFYUpucQK8RNiJspPp0pH91WJD2xQ@mail.gmail.com>
Subject: Re: [Qemu-devel] [RFC PATCH v4 06/15] net: port socket to GSource
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: liu ping fan <qemulist@gmail.com>
Cc: Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, mdroth <mdroth@linux.vnet.ibm.com>, Anthony Liguori <anthony@codemonkey.ws>, Jan Kiszka <jan.kiszka@siemens.com>, Paolo Bonzini <pbonzini@redhat.com>

On Fri, Apr 19, 2013 at 01:58:40PM +0800, liu ping fan wrote:
> On Thu, Apr 18, 2013 at 10:34 PM, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> > On Wed, Apr 17, 2013 at 04:39:15PM +0800, Liu Ping Fan wrote:
> > I'm a little worried that we're lacking G_IO_HUP | G_IO_ERR.  Perhaps
> > disconnect and network errors will be ignored.
> >
> NetSocketState can do limited things about these situation, perhaps,
> implement net_socket_can_receive() to export such message to frontend
> ?

net/socket.c uses G_IO_HUP | G_IO_ERR today, see
iohandler.c:qemu_iohandler_fill().

This patch *stops* using them.  My question is: why stop and is it
correct?

Stefan