From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUEUx-0003CA-7q for qemu-devel@nongnu.org; Mon, 22 Apr 2013 07:01:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUEUs-0008MZ-LR for qemu-devel@nongnu.org; Mon, 22 Apr 2013 07:01:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46157) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUEUs-0008MM-Dq for qemu-devel@nongnu.org; Mon, 22 Apr 2013 07:01:22 -0400 Date: Mon, 22 Apr 2013 14:00:01 +0300 From: Gleb Natapov Message-ID: <20130422110001.GP8997@redhat.com> References: <1366063976-4909-1-git-send-email-imammedo@redhat.com> <1366063976-4909-6-git-send-email-imammedo@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366063976-4909-6-git-send-email-imammedo@redhat.com> Subject: Re: [Qemu-devel] [PATCH 05/16] introduce CPU hot-plug notifier List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: aliguori@us.ibm.com, ehabkost@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, claudio.fontana@huawei.com, qemu-devel@nongnu.org, aderumier@odiso.com, lcapitulino@redhat.com, jfrei@linux.vnet.ibm.com, yang.z.zhang@intel.com, pbonzini@redhat.com, afaerber@suse.de, lig.fnst@cn.fujitsu.com, rth@twiddle.net On Tue, Apr 16, 2013 at 12:12:45AM +0200, Igor Mammedov wrote: > hot-added CPU will be distributed to acpi_piix4 and rtc_cmos > > Signed-off-by: Igor Mammedov > Reviewed-by: Paolo Bonzini > Reviewed-by: Eduardo Habkost > --- > v2: > * move notifier to qom/cpu.c and call it from CPUClass.realize() on hotplug > * remove get_firmware_id() since it belong to other patch > --- > include/sysemu/sysemu.h | 3 +++ > qom/cpu.c | 12 ++++++++++++ > 2 files changed, 15 insertions(+) > > diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h > index 6578782..a8c3de1 100644 > --- a/include/sysemu/sysemu.h > +++ b/include/sysemu/sysemu.h > @@ -152,6 +152,9 @@ void do_pci_device_hot_remove(Monitor *mon, const QDict *qdict); > /* generic hotplug */ > void drive_hot_add(Monitor *mon, const QDict *qdict); > > +/* CPU hotplug */ > +void qemu_register_cpu_added_notifier(Notifier *notifier); > + > /* pcie aer error injection */ > void pcie_aer_inject_error_print(Monitor *mon, const QObject *data); > int do_pcie_aer_inject_error(Monitor *mon, > diff --git a/qom/cpu.c b/qom/cpu.c > index 40a4259..819986e 100644 > --- a/qom/cpu.c > +++ b/qom/cpu.c > @@ -21,6 +21,17 @@ > #include "qom/cpu.h" > #include "qemu-common.h" > #include "sysemu/kvm.h" > +#include "qemu/notify.h" > +#include "sysemu/sysemu.h" > + > +/* CPU hot-plug notifiers */ > +static NotifierList cpu_added_notifiers = > + NOTIFIER_LIST_INITIALIZER(cpu_add_notifiers); > + > +void qemu_register_cpu_added_notifier(Notifier *notifier) > +{ > + notifier_list_add(&cpu_added_notifiers, notifier); > +} > > void cpu_reset_interrupt(CPUState *cpu, int mask) > { > @@ -61,6 +72,7 @@ static void cpu_common_realizefn(DeviceState *dev, Error **errp) > if (dev->hotplugged) { > cpu_synchronize_post_init(CPU(dev)); > resume_vcpu(CPU(dev)); > + notifier_list_notify(&cpu_added_notifiers, dev); Why do it after vcpu is running? May be notifier want to do something that should be done before vcpu is running. > } > } > > -- > 1.8.2 > > -- Gleb.