From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:41429) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUFDJ-0004UT-Vf for qemu-devel@nongnu.org; Mon, 22 Apr 2013 07:47:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUFDI-0007de-FS for qemu-devel@nongnu.org; Mon, 22 Apr 2013 07:47:17 -0400 Received: from mail-wi0-x235.google.com ([2a00:1450:400c:c05::235]:36185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUFDI-0007dR-9s for qemu-devel@nongnu.org; Mon, 22 Apr 2013 07:47:16 -0400 Received: by mail-wi0-f181.google.com with SMTP id c10so4178188wiw.14 for ; Mon, 22 Apr 2013 04:47:14 -0700 (PDT) Date: Mon, 22 Apr 2013 13:47:11 +0200 From: Stefan Hajnoczi Message-ID: <20130422114711.GA21317@stefanha-thinkpad.redhat.com> References: <1366284715-10107-1-git-send-email-s.fedorov@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1366284715-10107-1-git-send-email-s.fedorov@samsung.com> Subject: Re: [Qemu-devel] [PATCH] net/hub: remove can_receive handler List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Sergey Fedorov Cc: aliguori@us.ibm.com, a.basov@samsung.com, qemu-devel@nongnu.org, stefanha@redhat.com On Thu, Apr 18, 2013 at 03:31:55PM +0400, Sergey Fedorov wrote: > Network hub should always receive incoming packets. Then forward them to > the appropriate port queue and let the qemu_send_packet() do the right > things. If the destination queue cannot receive the packet it will be > appended to the queue. When the receiver call > qemu_flush_queued_packets() later the queue will be really flushed and > no packets will be stalled in the sender network queue. > > Signed-off-by: Sergey Fedorov > --- > net/hub.c | 20 -------------------- > 1 file changed, 20 deletions(-) What is the point of this change? There is no semantic difference for well-behaved net clients. Does it fix a bug, if so, please include details? Stefan