From: Stefan Hajnoczi <stefanha@gmail.com>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: kwolf@redhat.com, phrdina@redhat.com, qemu-devel@nongnu.org,
armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown
Date: Mon, 22 Apr 2013 15:53:43 +0200 [thread overview]
Message-ID: <20130422135343.GF21317@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1366393639-20651-1-git-send-email-lcapitulino@redhat.com>
On Fri, Apr 19, 2013 at 01:47:17PM -0400, Luiz Capitulino wrote:
> Hi,
>
> This fixes a regression introduced by commit 9ca111544, as detailed in
> patch 2/2, by moving bdrv_dev_change_media_cb() calls to callers of
> bdrv_close() that need it, as suggested by Kevin.
>
> Luiz Capitulino (2):
> block: make bdrv_dev_change_media_cb() public
> block: move bdrv_dev_change_media_cb() to callers that really need it
>
> block.c | 5 +----
> blockdev.c | 2 ++
> include/block/block.h | 1 +
> 3 files changed, 4 insertions(+), 4 deletions(-)
Looks okay but I'll wait for Markus or Kevin to review too. The media
change code is subtle, we've had a long history of fixes :).
Stefan
next prev parent reply other threads:[~2013-04-22 13:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 17:47 [Qemu-devel] [PATCH 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown Luiz Capitulino
2013-04-19 17:47 ` [Qemu-devel] [PATCH 1/2] block: make bdrv_dev_change_media_cb() public Luiz Capitulino
2013-04-25 13:57 ` Eric Blake
2013-04-19 17:47 ` [Qemu-devel] [PATCH 2/2] block: move bdrv_dev_change_media_cb() to callers that really need it Luiz Capitulino
2013-04-25 13:59 ` Eric Blake
2013-04-25 18:18 ` Markus Armbruster
2013-04-25 21:16 ` Luiz Capitulino
2013-04-26 11:35 ` Markus Armbruster
2013-05-21 15:54 ` Pavel Hrdina
2013-04-22 13:53 ` Stefan Hajnoczi [this message]
2013-04-25 13:51 ` [Qemu-devel] [PATCH 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown Luiz Capitulino
2013-04-25 14:29 ` Stefan Hajnoczi
2013-04-25 14:31 ` Luiz Capitulino
2013-05-17 14:23 ` Pavel Hrdina
2013-05-21 12:26 ` Luiz Capitulino
2013-05-21 12:56 ` Pavel Hrdina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130422135343.GF21317@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).