From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUbl5-0007U5-Ri for qemu-devel@nongnu.org; Tue, 23 Apr 2013 07:51:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUbl4-0001Mc-JR for qemu-devel@nongnu.org; Tue, 23 Apr 2013 07:51:39 -0400 Received: from e06smtp15.uk.ibm.com ([195.75.94.111]:34593) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUbl4-0001MX-8V for qemu-devel@nongnu.org; Tue, 23 Apr 2013 07:51:38 -0400 Received: from /spool/local by e06smtp15.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 23 Apr 2013 12:48:28 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id C6F941B08067 for ; Tue, 23 Apr 2013 12:51:33 +0100 (BST) Received: from d06av12.portsmouth.uk.ibm.com (d06av12.portsmouth.uk.ibm.com [9.149.37.247]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r3NBpNkW52691094 for ; Tue, 23 Apr 2013 11:51:23 GMT Received: from d06av12.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av12.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id r3NBpW2A007043 for ; Tue, 23 Apr 2013 05:51:33 -0600 Date: Tue, 23 Apr 2013 13:51:26 +0200 From: Cornelia Huck Message-ID: <20130423135126.1e12bf58@gondolin> In-Reply-To: <51767213.4050005@suse.de> References: <1366658298-9275-1-git-send-email-agraf@suse.de> <1366658298-9275-6-git-send-email-agraf@suse.de> <20130423105858.45feae1d@gondolin> <51767213.4050005@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/12] S390: ccw firmware: Add main program List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Christian Borntraeger , qemu-devel@nongnu.org, Dominik Dingel On Tue, 23 Apr 2013 13:35:47 +0200 Alexander Graf wrote: > On 04/23/2013 10:58 AM, Cornelia Huck wrote: > > On Mon, 22 Apr 2013 21:18:11 +0200 > > Alexander Graf wrote: > > > >> This C file is the main driving piece of the s390 ccw firmware. It > >> provides a search for a workable block device, sets it as the default > >> to boot off of and boots from it. > >> > >> Signed-off-by: Alexander Graf > >> --- > >> pc-bios/s390-ccw/main.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++ > >> 1 files changed, 56 insertions(+), 0 deletions(-) > >> create mode 100644 pc-bios/s390-ccw/main.c > >> > >> diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c > >> new file mode 100644 > >> index 0000000..0913aac > >> --- /dev/null > >> +++ b/pc-bios/s390-ccw/main.c > >> @@ -0,0 +1,56 @@ > >> +/* > >> + * S390 virtio-ccw loading program > >> + * > >> + * Copyright (c) 2013 Alexander Graf > >> + * > >> + * This work is licensed under the terms of the GNU GPL, version 2 or (at > >> + * your option) any later version. See the COPYING file in the top-level > >> + * directory. > >> + */ > >> + > >> +#include "s390-ccw.h" > >> + > >> +struct subchannel_id blk_schid; > >> +char stack[PAGE_SIZE * 8] __attribute__((__aligned__(PAGE_SIZE))); > >> + > >> +void virtio_panic(const char *string) > >> +{ > >> + sclp_print(string); > >> + while (1) { } > >> +} > >> + > >> +static void virtio_setup(void) > >> +{ > >> + struct irb irb; > >> + int i; > >> + int r; > >> + bool found = false; > >> + > >> + blk_schid.one = 1; > >> + > >> + for (i = 0; i< 0x10000; i++) { > >> + blk_schid.sch_no = i; > >> + r = tsch(blk_schid,&irb); > > You want to do a stsch() loop here, not a tsch() loop :) > > What does stsch buy us over tsch? A stsch() loop is the canonical way to find devices. tsch() is for updating subchannel status. And: > > As a bonus, you can exit the loop on cc == 3. :) > > > > r = stsch(blk_schid,&schib); > > if (r == 3) { > > break; > > } > > > >> + if (r != 3) { > > if (schib.pmcw.dnv) { > > > >> + if (virtio_is_blk(blk_schid)) { > >> + found = true; > >> + break; > >> + } > >> + } > >> + } > >> + > >> + if (!found) { > >> + virtio_panic("No virtio-blk device found!\n"); > >> + } > >> + > >> + virtio_setup_block(blk_schid); > > The virtio_is_blk() and virtio_setup_block() functions should go into a > > preceding patch, no? > > The code doesn't get compiled before the end of the series anyway, so > ordering might be slightly off :) > > > Alex >