From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57503)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1UUuMI-0004wi-1Q
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 03:43:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1UUuMG-0006HL-Gt
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 03:43:17 -0400
Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:39185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1UUuMG-0006HF-AL
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 03:43:16 -0400
Date: Wed, 24 Apr 2013 09:43:10 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130424074310.GG5000@ohm.aurel32.net>
References: <1366750012-25015-1-git-send-email-rth@twiddle.net>
	<1366750012-25015-18-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1366750012-25015-18-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v6 17/20] tcg-arm: Delete the 'S' constraint
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Tue, Apr 23, 2013 at 01:46:49PM -0700, Richard Henderson wrote:
> After the previous patch, 's' and 'S' are the same.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/arm/tcg-target.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index 375c1e1..5fa3cb1 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -201,8 +201,6 @@ static int target_parse_constraint(TCGArgConstraint *ct, const char **pct_str)
>  
>      /* qemu_st address & data_reg */
>      case 's':
> -    /* qemu_st64 data_reg2 */
> -    case 'S':
>          ct->ct |= TCG_CT_REG;
>          tcg_regset_set32(ct->u.regs, 0, (1 << TCG_TARGET_NB_REGS) - 1);
>          /* r0-r2 will be overwritten when reading the tlb entry (softmmu only)
> @@ -1928,7 +1926,7 @@ static const TCGTargetOpDef arm_op_defs[] = {
>      { INDEX_op_qemu_st8, { "s", "s" } },
>      { INDEX_op_qemu_st16, { "s", "s" } },
>      { INDEX_op_qemu_st32, { "s", "s" } },
> -    { INDEX_op_qemu_st64, { "S", "S", "s" } },
> +    { INDEX_op_qemu_st64, { "s", "s", "s" } },
>  #else
>      { INDEX_op_qemu_ld8u, { "r", "l", "l" } },
>      { INDEX_op_qemu_ld8s, { "r", "l", "l" } },
> @@ -1940,7 +1938,7 @@ static const TCGTargetOpDef arm_op_defs[] = {
>      { INDEX_op_qemu_st8, { "s", "s", "s" } },
>      { INDEX_op_qemu_st16, { "s", "s", "s" } },
>      { INDEX_op_qemu_st32, { "s", "s", "s" } },
> -    { INDEX_op_qemu_st64, { "S", "S", "s", "s" } },
> +    { INDEX_op_qemu_st64, { "s", "s", "s", "s" } },
>  #endif
>  
>      { INDEX_op_bswap16_i32, { "r", "r" } },

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net