From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:57731)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1UUuMp-0005a8-7r
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 03:43:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1UUuMn-0006Oy-Mg
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 03:43:51 -0400
Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:39193)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1UUuMn-0006Or-E4
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 03:43:49 -0400
Date: Wed, 24 Apr 2013 09:43:43 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130424074343.GI5000@ohm.aurel32.net>
References: <1366750012-25015-1-git-send-email-rth@twiddle.net>
	<1366750012-25015-21-git-send-email-rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1366750012-25015-21-git-send-email-rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v6 20/20] tcg-arm: Remove long jump from
 tcg_out_goto_label
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Tue, Apr 23, 2013 at 01:46:52PM -0700, Richard Henderson wrote:
> Branches within a TB will always be within 16MB.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  tcg/arm/tcg-target.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c
> index d6afa2f..7216f7a 100644
> --- a/tcg/arm/tcg-target.c
> +++ b/tcg/arm/tcg-target.c
> @@ -1055,14 +1055,9 @@ static inline void tcg_out_goto_label(TCGContext *s, int cond, int label_index)
>  {
>      TCGLabel *l = &s->labels[label_index];
>  
> -    if (l->has_value)
> +    if (l->has_value) {
>          tcg_out_goto(s, cond, l->u.value);
> -    else if (cond == COND_AL) {
> -        tcg_out_ld32_12(s, COND_AL, TCG_REG_PC, TCG_REG_PC, -4);
> -        tcg_out_reloc(s, s->code_ptr, R_ARM_ABS32, label_index, 31337);
> -        s->code_ptr += 4;
>      } else {
> -        /* Probably this should be preferred even for COND_AL... */
>          tcg_out_reloc(s, s->code_ptr, R_ARM_PC24, label_index, 31337);
>          tcg_out_b_noaddr(s, cond);
>      }

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net