From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUyrE-0005WF-Oq for qemu-devel@nongnu.org; Wed, 24 Apr 2013 08:31:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UUyrD-00027W-HZ for qemu-devel@nongnu.org; Wed, 24 Apr 2013 08:31:32 -0400 Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]:40367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UUyrD-00027L-B2 for qemu-devel@nongnu.org; Wed, 24 Apr 2013 08:31:31 -0400 Received: by mail-ea0-f182.google.com with SMTP id r16so725449ead.41 for ; Wed, 24 Apr 2013 05:31:30 -0700 (PDT) Date: Wed, 24 Apr 2013 14:31:27 +0200 From: Stefan Hajnoczi Message-ID: <20130424123127.GC24635@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU support of VHDX images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Tue, Apr 23, 2013 at 10:24:21AM -0400, Jeff Cody wrote: > +/* ---- HEADER SECTION STRUCTURES ---- */ > + > +/* Important note: these structures are as defined in the VHDX specification, > + * including byte order and size. However, without being packed structures, > + * they will not match 1:1 data read from disk. Rather than use potentially > + * non-portable packed structures, data is copied from read buffers into > + * the structures below. However, for reference, please refrain from > + * modifying these structures to something that does not represent the spec */ Outdated comment? The patch uses QEMU_PACKED. > +/* Header for the region table block */ > +#define VHDX_RT_MAGIC 0x69676572 /* 'regi ' */ Not worth respinnning, but should be 'regi' (4 bytes).