From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48405)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1UUyu8-0006O7-Ki
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 08:34:35 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1UUyu5-00039L-EV
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 08:34:32 -0400
Received: from mx1.redhat.com ([209.132.183.28]:23385)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1UUyu5-00038b-76
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 08:34:29 -0400
Date: Wed, 24 Apr 2013 08:34:25 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20130424123425.GC4131@localhost.localdomain>
References: <cover.1366726446.git.jcody@redhat.com>
	<f57fdf4c8563d591b0c4992151ebcd22abef5175.1366726446.git.jcody@redhat.com>
	<20130424123127.GC24635@stefanha-thinkpad.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130424123127.GC24635@stefanha-thinkpad.redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU
 support of VHDX images
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Apr 24, 2013 at 02:31:27PM +0200, Stefan Hajnoczi wrote:
> On Tue, Apr 23, 2013 at 10:24:21AM -0400, Jeff Cody wrote:
> > +/* ---- HEADER SECTION STRUCTURES ---- */
> > +
> > +/* Important note: these structures are as defined in the VHDX specification,
> > + * including byte order and size.  However, without being packed structures,
> > + * they will not match 1:1 data read from disk.  Rather than use potentially
> > + * non-portable packed structures, data is copied from read buffers into
> > + * the structures below.  However, for reference, please refrain from
> > + * modifying these structures to something that does not represent the spec */
> 
> Outdated comment?  The patch uses QEMU_PACKED.
> 

Yes, outdated comment, thanks.

> > +/* Header for the region table block */
> > +#define VHDX_RT_MAGIC 0x69676572  /* 'regi ' */
> 
> Not worth respinnning, but should be 'regi' (4 bytes).

Per Kevin's comments, I am removing all the _MAGIC's from the
headers anyway, and using memcmp against the strings in the source
file.  So I'll take care of the outdated comment as well then.