From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38241)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1UV26x-00063v-9b
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 12:00:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1UV26s-0005Wz-Jl
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 11:59:59 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48502)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <akong@redhat.com>) id 1UV26s-0005Wq-B2
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 11:59:54 -0400
Date: Wed, 24 Apr 2013 23:59:47 +0800
From: Amos Kong <akong@redhat.com>
Message-ID: <20130424155947.GA3005@t430s.nay.redhat.com>
References: <1366807646-8473-1-git-send-email-akong@redhat.com>
	<5177E5CE.6040101@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5177E5CE.6040101@redhat.com>
Subject: Re: [Qemu-devel] [RESEND PATCH 1/2] qapi: introduce strList and
 visit_type_strList()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, jyang@redhat.com, lcapitulino@redhat.com

On Wed, Apr 24, 2013 at 08:01:50AM -0600, Eric Blake wrote:
> On 04/24/2013 06:47 AM, Amos Kong wrote:
> > Currently we can only use ['String'] to add string to a list,
> > it contains some additional JSON structure.
> >     "multicast": [
> >         {
> >             "str": "01:80:c2:00:00:21"
> >         },
> >         {
> >             "str": "00:00:00:00:00:00"
> >         }
> >     ]
> > 
> > This patch introdued strList, we can use ['str']
> > 
> >     "multicast": [
> >         "01:00:5e:00:00:01",
> >         "33:33:ff:12:34:57"
> >     ]
> > 
> > Signed-off-by: Amos Kong <akong@redhat.com>
> > ---
> > I used an _ugly_ "#ifndef" to limit it only be defined in qapi-types.h.
> > do you have some suggestion to fix it?
> 
> I'm not the maintainer, so you may still want to wait for a better
> suggestion.  But since I personally don't mind the #ifdef if that's what
> it takes to get this to compile, and since I'd like to see the feature
> added, I'm fine giving:
 
I will send a v2 to solve this issue.

> Reviewed-by: Eric Blake <eblake@redhat.com>
> 
> That said, I think the API in patch 2/2 is not quite right; and when you
> fix things there, you may not need this patch in the 1.5 timeframe...

I already saw your comment, will split those two patches.
Thanks

-- 
			Amos.