From: Luiz Capitulino <lcapitulino@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities
Date: Wed, 24 Apr 2013 17:30:59 -0400 [thread overview]
Message-ID: <20130424173059.75089c4a@redhat.com> (raw)
In-Reply-To: <51784D95.7050305@redhat.com>
On Wed, 24 Apr 2013 23:24:37 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:
> Il 24/04/2013 22:36, Luiz Capitulino ha scritto:
> > The drive-mirror command was extended in QEMU v1.3.0 with two new
> > optional arguments 'granularity' and 'buf-size'. However, there's
> > no way for libvirt to query for the existence of the new arguments.
> >
> > This commit solves this problem by adding the
> > query-drive-mirror-capabilities command, which reports the
> > existence of both arguments.
> >
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
>
> NACK, libvirt doesn't need it yet. Let's do it properly in 1.6.
NACK taken.
Did this on Eric's request but now I see we have all agreed on
deferring a proper solution to 1.6.
prev parent reply other threads:[~2013-04-24 21:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 20:36 [Qemu-devel] [PATCH for-1.5] qmp: add query-drive-mirror-capabilities Luiz Capitulino
2013-04-24 21:05 ` Eric Blake
2013-04-24 21:29 ` Luiz Capitulino
2013-04-24 21:59 ` Eric Blake
2013-04-24 22:06 ` Eric Blake
2013-04-25 12:26 ` Luiz Capitulino
2013-04-26 8:13 ` Paolo Bonzini
2013-04-26 13:40 ` Markus Armbruster
2013-04-26 13:54 ` Luiz Capitulino
2013-04-26 15:25 ` Markus Armbruster
2013-04-24 21:24 ` Paolo Bonzini
2013-04-24 21:30 ` Luiz Capitulino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130424173059.75089c4a@redhat.com \
--to=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).