From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59139)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UV7HK-0008T1-5A
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 17:31:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UV7HJ-0003WL-At
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 17:31:02 -0400
Received: from mx1.redhat.com ([209.132.183.28]:5273)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UV7HJ-0003W4-3F
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 17:31:01 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3OLV0v0025071
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 24 Apr 2013 17:31:00 -0400
Date: Wed, 24 Apr 2013 17:30:59 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130424173059.75089c4a@redhat.com>
In-Reply-To: <51784D95.7050305@redhat.com>
References: <20130424163641.3e15bd43@redhat.com> <51784D95.7050305@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for-1.5] qmp: add
	query-drive-mirror-capabilities
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

On Wed, 24 Apr 2013 23:24:37 +0200
Paolo Bonzini <pbonzini@redhat.com> wrote:

> Il 24/04/2013 22:36, Luiz Capitulino ha scritto:
> > The drive-mirror command was extended in QEMU v1.3.0 with two new
> > optional arguments 'granularity' and 'buf-size'. However, there's
> > no way for libvirt to query for the existence of the new arguments.
> > 
> > This commit solves this problem by adding the
> > query-drive-mirror-capabilities command, which reports the
> > existence of both arguments.
> > 
> > Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> 
> NACK, libvirt doesn't need it yet.  Let's do it properly in 1.6.

NACK taken.

Did this on Eric's request but now I see we have all agreed on
deferring a proper solution to 1.6.