From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:36891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hutao@cn.fujitsu.com>) id 1UVC0I-0002gG-1E
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:33:50 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <hutao@cn.fujitsu.com>) id 1UVC0D-0007Y7-Dz
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:33:45 -0400
Received: from [222.73.24.84] (port=33554 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <hutao@cn.fujitsu.com>) id 1UVC0D-0007Xu-3J
	for qemu-devel@nongnu.org; Wed, 24 Apr 2013 22:33:41 -0400
Date: Thu, 25 Apr 2013 10:33:04 +0800
From: Hu Tao <hutao@cn.fujitsu.com>
Message-ID: <20130425023304.GF10084@localhost.localdomain>
References: <cover.1366354934.git.hutao@cn.fujitsu.com>
	<1390418ac8a8641e9084ce13e1421750cbf4dcf9.1366354934.git.hutao@cn.fujitsu.com>
	<87zjwn99dj.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
In-Reply-To: <87zjwn99dj.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Subject: Re: [Qemu-devel] [PATCH v20 6/7] pvpanic: create pvpanic by default
 for machine 1.5
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On Wed, Apr 24, 2013 at 06:33:12PM +0200, Markus Armbruster wrote:
> You forgot to suppress the pvpanic device with the really old machine
> types using pc_init_pci_no_kvmclock().

Thanks for pointing it out!

> 
> $ for i in `qemu-system-x86_64 -M help | awk '/^[a-z]/ { print $1 }'| grep -v xen`; do echo -n $i; echo -e "info qtree\nq" | qemu-system-x86_64 -nodefaults -S -nographic -monitor stdio -M $i | grep pvpanic || echo; done
> pc          dev: pvpanic, id ""
> pc-i440fx-1.5          dev: pvpanic, id ""
> pc-i440fx-1.4
> pc-1.3
> pc-1.2
> pc-1.1
> pc-1.0
> pc-0.15
> pc-0.14
> pc-0.13          dev: pvpanic, id ""
> pc-0.12          dev: pvpanic, id ""
> pc-0.11          dev: pvpanic, id ""
> pc-0.10          dev: pvpanic, id ""
> isapc      dev: pvpanic, id ""
> q35          dev: pvpanic, id ""
> pc-q35-1.5          dev: pvpanic, id ""
> pc-q35-1.4
> 
> Sorry I didn't catch this earlier.