From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54751)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <martin@duskware.de>) id 1UVFxZ-0004FQ-GA
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 02:47:15 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <martin@duskware.de>) id 1UVFxW-0001eM-8V
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 02:47:13 -0400
Received: from mail.duskware.de ([91.199.88.144]:57620)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <martin@duskware.de>) id 1UVFxW-0001cn-1z
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 02:47:10 -0400
Date: Thu, 25 Apr 2013 08:47:01 +0200
From: Martin Husemann <martin@duskware.de>
Message-ID: <20130425064701.GA9899@mail.duskware.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Subject: [Qemu-devel] Git head build problem (popcountl vs. system headers)
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

I just tried building git HEAD on NetBSD-current and gcc chokes on
a prototype mismatch for popcountl:

util/hbitmap.c has:

static inline int popcountl(unsigned long l)
{
    return BITS_PER_LONG == 32 ? ctpop32(l) : ctpop64(l);
}

while NetBSD's strings.h uses:

unsigned int        popcountl(unsigned long) __constfunc;


"unsigned" looks better to me for a non negative count, but maybe a
configure test and using the system libs would be preferable?

Martin