From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVIHT-0000Yn-T3 for qemu-devel@nongnu.org; Thu, 25 Apr 2013 05:16:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVIHM-0006sR-PC for qemu-devel@nongnu.org; Thu, 25 Apr 2013 05:15:55 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVIHM-0006sB-Hy for qemu-devel@nongnu.org; Thu, 25 Apr 2013 05:15:48 -0400 Date: Thu, 25 Apr 2013 09:20:14 +0200 From: Stefan Hajnoczi Message-ID: <20130425072014.GA32281@stefanha-thinkpad.redhat.com> References: <4fe304399e0d00138fefcfffaae97ae5a16de552.1366726446.git.jcody@redhat.com> <20130424144715.GF24635@stefanha-thinkpad.redhat.com> <20130424145619.GE4131@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130424145619.GE4131@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH v2 5/5] block: add header update capability for VHDX images. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, Stefan Hajnoczi , qemu-devel@nongnu.org On Wed, Apr 24, 2013 at 10:56:19AM -0400, Jeff Cody wrote: > On Wed, Apr 24, 2013 at 04:47:15PM +0200, Stefan Hajnoczi wrote: > > On Tue, Apr 23, 2013 at 10:24:24AM -0400, Jeff Cody wrote: > > > This adds the ability to update the headers in a VHDX image, including > > > generating a new MS-compatible GUID. > > > > > > As VHDX depends on uuid.h, VHDX is now a configurable build option. > > > If VHDX support is enabled, that will also enable uuid as well. > > > > > > To enable/disable VHDX: --enable-vhdx, --disable-vhdx > > > > > > Signed-off-by: Jeff Cody > > > --- > > > block/Makefile.objs | 2 +- > > > block/vhdx.c | 157 +++++++++++++++++++++++++++++++++++++++++++++++++++- > > > configure | 13 +++++ > > > 3 files changed, 169 insertions(+), 3 deletions(-) > > > > Why is this part of the series? > > > > Stefan > > This could technically be dropped from the series, since the current > series only supports r/o functions. > > I included it because it is not log-dependent - This patch provides > the basic mechanism to update the headers (header updates do not go > through the log), so it is safe. It is not required yet, but it will > be in the future. I suggest putting this patch into the series that makes use of it. Stefan