Re: [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU support of VHDX images

[Kevin Wolf <kwolf@redhat.com>]

Am 23.04.2013 um 16:24 hat Jeff Cody geschrieben:
> This is based on Microsoft's VHDX specification:
>     "VHDX Format Specification v0.95", published 4/12/2012
>     https://www.microsoft.com/en-us/download/details.aspx?id=29681
> 
> These structures define the various header, metadata, and other
> block structures defined in the VHDX specification.
> 
> Signed-off-by: Jeff Cody <jcody@redhat.com>
> ---
>  block/vhdx.h | 327 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 327 insertions(+)
>  create mode 100644 block/vhdx.h

> +typedef struct QEMU_PACKED vhdx_page83_data {
> +    uint8_t     page_83_data[16];       /* unique id for scsi devices that
> +                                           support page 0x83 */
> +} vhdx_page83_data;

Why uint8_t[16] instead of ms_guid?

> +
> +typedef struct QEMU_PACKED vhdx_virtual_disk_logical_sector_size {
> +    uint32_t    logical_sector_size;    /* virtual disk sector size (in bytes).
> +                                           Can only be 512 or 4096 bytes */
> +} vhdx_virtual_disk_logical_sector_size;
> +
> +typedef struct QEMU_PACKED vhdx_virtual_disk_physical_sector_size {
> +    uint32_t    physical_sector_size;   /* physical sector size (in bytes).
> +                                           Can only be 512 or 4096 bytes */
> +} vhdx_virtual_disk_physical_sector_size;
> +
> +typedef struct QEMU_PACKED vhdx_parent_locator_header {
> +    uint8_t     locator_type[16];       /* type of the parent virtual disk. */

Same question here.

> +    uint16_t    reserved;
> +    uint16_t    key_value_count;        /* number of key/value pairs for this
> +                                           locator */
> +} vhdx_parent_locator_header;

Kevin