From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56515) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVLrt-0006uj-SI for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:05:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVLro-0008Sy-De for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:05:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVLro-0008So-1g for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:05:40 -0400 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3PD5dsN022423 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 25 Apr 2013 09:05:39 -0400 Date: Thu, 25 Apr 2013 15:05:37 +0200 From: Kevin Wolf Message-ID: <20130425130537.GC3156@dhcp-200-207.str.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU support of VHDX images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: qemu-devel@nongnu.org, stefanha@redhat.com Am 23.04.2013 um 16:24 hat Jeff Cody geschrieben: > This is based on Microsoft's VHDX specification: > "VHDX Format Specification v0.95", published 4/12/2012 > https://www.microsoft.com/en-us/download/details.aspx?id=29681 > > These structures define the various header, metadata, and other > block structures defined in the VHDX specification. > > Signed-off-by: Jeff Cody > --- > block/vhdx.h | 327 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 327 insertions(+) > create mode 100644 block/vhdx.h > +typedef struct QEMU_PACKED vhdx_page83_data { > + uint8_t page_83_data[16]; /* unique id for scsi devices that > + support page 0x83 */ > +} vhdx_page83_data; Why uint8_t[16] instead of ms_guid? > + > +typedef struct QEMU_PACKED vhdx_virtual_disk_logical_sector_size { > + uint32_t logical_sector_size; /* virtual disk sector size (in bytes). > + Can only be 512 or 4096 bytes */ > +} vhdx_virtual_disk_logical_sector_size; > + > +typedef struct QEMU_PACKED vhdx_virtual_disk_physical_sector_size { > + uint32_t physical_sector_size; /* physical sector size (in bytes). > + Can only be 512 or 4096 bytes */ > +} vhdx_virtual_disk_physical_sector_size; > + > +typedef struct QEMU_PACKED vhdx_parent_locator_header { > + uint8_t locator_type[16]; /* type of the parent virtual disk. */ Same question here. > + uint16_t reserved; > + uint16_t key_value_count; /* number of key/value pairs for this > + locator */ > +} vhdx_parent_locator_header; Kevin