From: Stefan Hajnoczi <stefanha@gmail.com>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 5/6] vmdk: store fields of VmdkMetaData in cpu endian
Date: Thu, 25 Apr 2013 15:20:47 +0200 [thread overview]
Message-ID: <20130425132047.GA10819@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1366807475-26350-6-git-send-email-famz@redhat.com>
On Wed, Apr 24, 2013 at 08:44:34PM +0800, Fam Zheng wrote:
> @@ -938,7 +938,7 @@ static int get_cluster_offset(BlockDriverState *bs,
> }
>
> if (m_data) {
> - m_data->offset = tmp;
> + m_data->offset = *cluster_offset;
tmp can be dropped now:
-tmp = cpu_to_le32(*cluster_offset);
-l2_table[l2_index] = tmp;
+l2_table[l2_index] = cpu_to_le32(*cluster_offset);
next prev parent reply other threads:[~2013-04-25 13:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-24 12:44 [Qemu-devel] [PATCH v3 0/6] vmdk: zeroed-grain GTE support Fam Zheng
2013-04-24 12:44 ` [Qemu-devel] [PATCH v3 1/6] vmdk: named return code Fam Zheng
2013-04-24 12:44 ` [Qemu-devel] [PATCH v3 2/6] vmdk: add support for “zeroed‐grain” GTE Fam Zheng
2013-04-24 12:44 ` [Qemu-devel] [PATCH v3 3/6] vmdk: Add option to create zeroed-grain image Fam Zheng
2013-04-24 12:44 ` [Qemu-devel] [PATCH v3 4/6] vmdk: change magic number to macro Fam Zheng
2013-04-24 12:44 ` [Qemu-devel] [PATCH v3 5/6] vmdk: store fields of VmdkMetaData in cpu endian Fam Zheng
2013-04-25 13:20 ` Stefan Hajnoczi [this message]
2013-04-24 12:44 ` [Qemu-devel] [PATCH v3 6/6] vmdk: add bdrv_co_write_zeroes Fam Zheng
2013-04-25 13:20 ` Stefan Hajnoczi
2013-04-25 13:25 ` [Qemu-devel] [PATCH v3 0/6] vmdk: zeroed-grain GTE support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130425132047.GA10819@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).