From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34265)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UVMBV-00018C-PW
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:26:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UVMBQ-0006Ky-Sw
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:26:01 -0400
Received: from mail-wi0-x229.google.com ([2a00:1450:400c:c05::229]:64028)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1UVMBQ-0006Ko-Gf
	for qemu-devel@nongnu.org; Thu, 25 Apr 2013 09:25:56 -0400
Received: by mail-wi0-f169.google.com with SMTP id h11so9169367wiv.0
	for <qemu-devel@nongnu.org>; Thu, 25 Apr 2013 06:25:55 -0700 (PDT)
Date: Thu, 25 Apr 2013 15:25:52 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20130425132552.GB10819@stefanha-thinkpad.redhat.com>
References: <1366807475-26350-1-git-send-email-famz@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1366807475-26350-1-git-send-email-famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 0/6] vmdk: zeroed-grain GTE support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com

On Wed, Apr 24, 2013 at 08:44:29PM +0800, Fam Zheng wrote:
> Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1].
> 
> [1] Virtual Disk Format 5.0 - VMware,
>     http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk
> 
> Changes since v2:
>  - all: Added 5/6 (vmdk: store fields of VmdkMetaData in cpu endian)
>  - 6/6: Avoid side-effect of vmdk_L2update.
>         Change function comment to gtkdoc stype.
>         Fix VMDK4_FLAG_ZG.

I left some comments.  The trickiest one is forgetting to update the
l2_cache[].  If more vmdk.c features are added in the future, please
first switch to common caching code that qcow2 uses.  Right now just
fixing the missing cache update is fine.

Dong Xu Wang <wdongxu@linux.vnet.ibm.com> has moved the qcow2 cache code
to a common place.  His patches aren't merged yet but should be soon.

Stefan