From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59803) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVNAv-0001ZX-3D for qemu-devel@nongnu.org; Thu, 25 Apr 2013 10:29:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVNAr-0006lV-Nc for qemu-devel@nongnu.org; Thu, 25 Apr 2013 10:29:29 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVNAr-0006kF-FO for qemu-devel@nongnu.org; Thu, 25 Apr 2013 10:29:25 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3PETOWY032595 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 25 Apr 2013 10:29:24 -0400 Date: Thu, 25 Apr 2013 10:29:20 -0400 From: Jeff Cody Message-ID: <20130425142920.GA3525@localhost.localdomain> References: <20130425130537.GC3156@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130425130537.GC3156@dhcp-200-207.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/5] block: vhdx header for the QEMU support of VHDX images List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org, stefanha@redhat.com On Thu, Apr 25, 2013 at 03:05:37PM +0200, Kevin Wolf wrote: > Am 23.04.2013 um 16:24 hat Jeff Cody geschrieben: > > This is based on Microsoft's VHDX specification: > > "VHDX Format Specification v0.95", published 4/12/2012 > > https://www.microsoft.com/en-us/download/details.aspx?id=29681 > > > > These structures define the various header, metadata, and other > > block structures defined in the VHDX specification. > > > > Signed-off-by: Jeff Cody > > --- > > block/vhdx.h | 327 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 327 insertions(+) > > create mode 100644 block/vhdx.h > > > +typedef struct QEMU_PACKED vhdx_page83_data { > > + uint8_t page_83_data[16]; /* unique id for scsi devices that > > + support page 0x83 */ > > +} vhdx_page83_data; > > Why uint8_t[16] instead of ms_guid? > > > + > > +typedef struct QEMU_PACKED vhdx_virtual_disk_logical_sector_size { > > + uint32_t logical_sector_size; /* virtual disk sector size (in bytes). > > + Can only be 512 or 4096 bytes */ > > +} vhdx_virtual_disk_logical_sector_size; > > + > > +typedef struct QEMU_PACKED vhdx_virtual_disk_physical_sector_size { > > + uint32_t physical_sector_size; /* physical sector size (in bytes). > > + Can only be 512 or 4096 bytes */ > > +} vhdx_virtual_disk_physical_sector_size; > > + > > +typedef struct QEMU_PACKED vhdx_parent_locator_header { > > + uint8_t locator_type[16]; /* type of the parent virtual disk. */ > > Same question here. > You are right, those should both be ms_guid. > > + uint16_t reserved; > > + uint16_t key_value_count; /* number of key/value pairs for this > > + locator */ > > +} vhdx_parent_locator_header; > > Kevin