From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59958) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVNBI-0001v9-1q for qemu-devel@nongnu.org; Thu, 25 Apr 2013 10:29:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVNBF-0006yW-A1 for qemu-devel@nongnu.org; Thu, 25 Apr 2013 10:29:52 -0400 Received: from mail-wg0-x22b.google.com ([2a00:1450:400c:c00::22b]:53506) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVNBF-0006yI-2M for qemu-devel@nongnu.org; Thu, 25 Apr 2013 10:29:49 -0400 Received: by mail-wg0-f43.google.com with SMTP id c11so1477175wgh.34 for ; Thu, 25 Apr 2013 07:29:48 -0700 (PDT) Date: Thu, 25 Apr 2013 16:29:45 +0200 From: Stefan Hajnoczi Message-ID: <20130425142945.GA11388@stefanha-thinkpad.redhat.com> References: <1366393639-20651-1-git-send-email-lcapitulino@redhat.com> <20130422135343.GF21317@stefanha-thinkpad.redhat.com> <20130425095147.75b90841@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130425095147.75b90841@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] block: fix spurious DEVICE_TRAY_MOVED events on shutdown List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: kwolf@redhat.com, phrdina@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Thu, Apr 25, 2013 at 09:51:47AM -0400, Luiz Capitulino wrote: > On Mon, 22 Apr 2013 15:53:43 +0200 > Stefan Hajnoczi wrote: > > > On Fri, Apr 19, 2013 at 01:47:17PM -0400, Luiz Capitulino wrote: > > > Hi, > > > > > > This fixes a regression introduced by commit 9ca111544, as detailed in > > > patch 2/2, by moving bdrv_dev_change_media_cb() calls to callers of > > > bdrv_close() that need it, as suggested by Kevin. > > > > > > Luiz Capitulino (2): > > > block: make bdrv_dev_change_media_cb() public > > > block: move bdrv_dev_change_media_cb() to callers that really need it > > > > > > block.c | 5 +---- > > > blockdev.c | 2 ++ > > > include/block/block.h | 1 + > > > 3 files changed, 4 insertions(+), 4 deletions(-) > > > > Looks okay but I'll wait for Markus or Kevin to review too. The media > > change code is subtle, we've had a long history of fixes :). > > I wouldn't say this is hugely important, but I'm targeting 1.5. > > So, maybe lack of review means you could apply it? :) Nice try :) We've never gotten media change right. I really would appreciate a second pair of eyes. There are still a couple of days until hard freeze. Holding off until then. Stefan