From: Stefan Hajnoczi <stefanha@redhat.com>
To: Liu Ping Fan <qemulist@gmail.com>
Cc: mdroth <mdroth@linux.vnet.ibm.com>,
Jan Kiszka <jan.kiszka@siemens.com>,
qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH v5 04/14] net: port vde onto GSource
Date: Fri, 26 Apr 2013 11:25:12 +0200 [thread overview]
Message-ID: <20130426092512.GD17609@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1366944455-14239-5-git-send-email-qemulist@gmail.com>
On Fri, Apr 26, 2013 at 10:47:25AM +0800, Liu Ping Fan wrote:
> +static gboolean vde_handler(gpointer data)
> +{
> + EventGSource *nsrc = (EventGSource *)data;
> +
> + if (nsrc->gfd.revents & G_IO_IN) {
The VDE file descriptor is a socket. Please use the full G_IO_IN |
G_IO_HUP | G_IO_ERR set which is equivalent to select(2) rfds. This
ensures we handle errors and disconnect.
next prev parent reply other threads:[~2013-04-26 9:27 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 2:47 [Qemu-devel] [RFC PATCH v5 00/14] port network layer onto glib Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 01/14] util: introduce gsource event abstraction Liu Ping Fan
2013-04-26 9:19 ` Stefan Hajnoczi
2013-04-27 2:11 ` liu ping fan
2013-04-29 8:00 ` Stefan Hajnoczi
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 02/14] net: introduce bind_ctx to NetClientInfo Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 03/14] net: port tap onto GSource Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 04/14] net: port vde " Liu Ping Fan
2013-04-26 9:25 ` Stefan Hajnoczi [this message]
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 05/14] net: port socket to GSource Liu Ping Fan
2013-04-26 9:48 ` Stefan Hajnoczi
2013-04-27 7:09 ` liu ping fan
2013-04-29 8:21 ` Stefan Hajnoczi
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 06/14] net: port tap-win32 onto GSource Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 07/14] net: hub use lock to protect ports list Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 08/14] net: introduce lock to protect NetQueue Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 09/14] net: introduce lock to protect NetClientState's peer's access Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 10/14] net: make netclient re-entrant with refcnt Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 11/14] slirp: make timeout local Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 12/14] slirp: make slirp event dispatch based on slirp instance, not global Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 13/14] slirp: handle race condition Liu Ping Fan
2013-04-26 2:47 ` [Qemu-devel] [RFC PATCH v5 14/14] slirp: use lock to protect the slirp_instances Liu Ping Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130426092512.GD17609@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=jan.kiszka@siemens.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemulist@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).