* [Qemu-devel] [PATCH] PPC: Fix dcbz for linux-user on 970
@ 2013-04-26 7:20 Alexander Graf
2013-04-26 10:18 ` Riku Voipio
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Graf @ 2013-04-26 7:20 UTC (permalink / raw)
To: qemu-ppc; +Cc: Riku Voipio, qemu-devel
The default with linux-user for dcbz on 970 is to emulate 32 byte clears.
However, redoing the dcbzl support we added a check to not honor the bit
in HID5 that sets this.
Remove the #ifdef check on linux user, so that we get 32 byte clears again.
Reported-by: Riku Voipio <riku.voipio@iki.fi>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
target-ppc/mem_helper.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-ppc/mem_helper.c b/target-ppc/mem_helper.c
index 9783e52..d8e63ca 100644
--- a/target-ppc/mem_helper.c
+++ b/target-ppc/mem_helper.c
@@ -140,7 +140,7 @@ void helper_dcbz(CPUPPCState *env, target_ulong addr, uint32_t is_dcbzl)
{
int dcbz_size = env->dcache_line_size;
-#if !defined(CONFIG_USER_ONLY) && defined(TARGET_PPC64)
+#if defined(TARGET_PPC64)
if (!is_dcbzl &&
(env->excp_model == POWERPC_EXCP_970) &&
((env->spr[SPR_970_HID5] >> 7) & 0x3) == 1) {
--
1.6.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] PPC: Fix dcbz for linux-user on 970
2013-04-26 7:20 [Qemu-devel] [PATCH] PPC: Fix dcbz for linux-user on 970 Alexander Graf
@ 2013-04-26 10:18 ` Riku Voipio
0 siblings, 0 replies; 2+ messages in thread
From: Riku Voipio @ 2013-04-26 10:18 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-ppc, qemu-devel
On Fri, Apr 26, 2013 at 09:20:51AM +0200, Alexander Graf wrote:
> The default with linux-user for dcbz on 970 is to emulate 32 byte clears.
> However, redoing the dcbzl support we added a check to not honor the bit
> in HID5 that sets this.
>
> Remove the #ifdef check on linux user, so that we get 32 byte clears again.
This fixes ppc64-linux-user for my smoke tests, thanks.
Tested-By: <riku.voipio@iki.fi>
> Reported-by: Riku Voipio <riku.voipio@iki.fi>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> target-ppc/mem_helper.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-ppc/mem_helper.c b/target-ppc/mem_helper.c
> index 9783e52..d8e63ca 100644
> --- a/target-ppc/mem_helper.c
> +++ b/target-ppc/mem_helper.c
> @@ -140,7 +140,7 @@ void helper_dcbz(CPUPPCState *env, target_ulong addr, uint32_t is_dcbzl)
> {
> int dcbz_size = env->dcache_line_size;
>
> -#if !defined(CONFIG_USER_ONLY) && defined(TARGET_PPC64)
> +#if defined(TARGET_PPC64)
> if (!is_dcbzl &&
> (env->excp_model == POWERPC_EXCP_970) &&
> ((env->spr[SPR_970_HID5] >> 7) & 0x3) == 1) {
> --
> 1.6.0.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-26 10:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-26 7:20 [Qemu-devel] [PATCH] PPC: Fix dcbz for linux-user on 970 Alexander Graf
2013-04-26 10:18 ` Riku Voipio
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).