From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42203) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVgek-0000yr-HO for qemu-devel@nongnu.org; Fri, 26 Apr 2013 07:17:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UVgef-0000Dr-TV for qemu-devel@nongnu.org; Fri, 26 Apr 2013 07:17:34 -0400 Received: from ozlabs.org ([2402:b800:7003:1:1::1]:47998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UVgef-0000DW-HR for qemu-devel@nongnu.org; Fri, 26 Apr 2013 07:17:29 -0400 Date: Fri, 26 Apr 2013 21:04:01 +1000 From: David Gibson Message-ID: <20130426110401.GA4360@truffula.fritz.box> References: <1366956141-2066-1-git-send-email-david@gibson.dropbear.id.au> <1366956141-2066-2-git-send-email-david@gibson.dropbear.id.au> <517A38AB.6030600@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IJpNTDwzlM2Ie8A6" Content-Disposition: inline In-Reply-To: <517A38AB.6030600@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/4] Fix vmw_pvscsi.c for iommu support changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: aik@ozlabs.ru, alex.williamson@redhat.com, qemu-devel@nongnu.org --IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 26, 2013 at 10:19:55AM +0200, Paolo Bonzini wrote: > Il 26/04/2013 08:02, David Gibson ha scritto: > > vmw_pvscsi.c directly calls pci_dma_sglist_init() instead of using the > > helper for PCI devices, which means it was broken by Paolo Bonzini's > > recent addition of iommu support to the memory API. This fixes it. > >=20 > > Signed-off-by: David Gibson > > --- > > hw/scsi/vmw_pvscsi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c > > index 4b4a58f..68c8d58 100644 > > --- a/hw/scsi/vmw_pvscsi.c > > +++ b/hw/scsi/vmw_pvscsi.c > > @@ -617,7 +617,7 @@ pvscsi_build_sglist(PVSCSIState *s, PVSCSIRequest *= r) > > { > > PCIDevice *d =3D PCI_DEVICE(s); > > =20 > > - qemu_sglist_init(&r->sgl, 1, pci_dma_context(d)); > > + pci_dma_sglist_init(&r->sgl, d, 1); > > if (r->req.flags & PVSCSI_FLAG_CMD_WITH_SG_LIST) { > > pvscsi_convert_sglist(r); > > } else { > >=20 >=20 > Thanks for the heads-up. Though maybe it should just bypass the IOMMU > like virtio, I'll think about it. Well, maybe. virtio shouldn't really bypass the iommu, that's basically a historical bug in the specification. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iEYEARECAAYFAlF6XyEACgkQaILKxv3ab8aPXACeMeOVjQTcD7DnYme9XXRTD3u3 jyYAoJNcOfaXrCu6kP9qhoWUsyspGWCq =gDzw -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--