From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35570)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UVkk5-00030e-2h
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:39:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UVkk3-0007hA-G9
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:39:20 -0400
Received: from mx1.redhat.com ([209.132.183.28]:47533)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <imammedo@redhat.com>) id 1UVkk3-0007fs-74
	for qemu-devel@nongnu.org; Fri, 26 Apr 2013 11:39:19 -0400
Date: Fri, 26 Apr 2013 17:39:15 +0200
From: Igor Mammedov <imammedo@redhat.com>
Message-ID: <20130426173915.20d02c7d@thinkpad>
In-Reply-To: <517A9E3E.2060901@suse.de>
References: <1366915386-14728-1-git-send-email-ehabkost@redhat.com>
	<1366915386-14728-8-git-send-email-ehabkost@redhat.com>
	<20130426171029.3e159116@thinkpad>
	<20130426153108.GX2900@otherpad.lan.raisama.net>
	<517A9E3E.2060901@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC 7/7] target-i386: Disable direct passthrough
 of PMU CPUID leaf by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?ISO-8859-1?B?RuRyYmVy?= <afaerber@suse.de>
Cc: Eduardo Habkost <ehabkost@redhat.com>, Gleb Natapov <gleb@redhat.com>, qemu-devel@nongnu.org

On Fri, 26 Apr 2013 17:33:18 +0200
Andreas F=E4rber <afaerber@suse.de> wrote:

> Am 26.04.2013 17:31, schrieb Eduardo Habkost:
> > On Fri, Apr 26, 2013 at 05:10:29PM +0200, Igor Mammedov wrote:
> >> On Thu, 25 Apr 2013 15:43:06 -0300
> >> Eduardo Habkost <ehabkost@redhat.com> wrote:
> >>
> >>> The current code handling the CPUID 0xA leaf simply forwards all data
> >>> from GET_SUPPORTED_CPUID directly to the guest, breaking migration
> >>> between hosts with different number of PMU counters.
> >>>
> >>> This patch disables this behavior, except on older machine-types (for
> >>> compatibility) and on the "host" CPU model.
> >> Please, make it static property and use compat properties.
> >> Result will be simpler and  much less will have to be redone/discarded=
 after
> >> converting to the rest to properties and sub-classes.
> >=20
> > I was going to say that static properties were too much work to be done
> > in time for 1.5, but you are right: in this specific case adding a
> > static property for the cpuid_pmu_passthrough field looks very easy. I
> > will give it a try.
>=20
> I am hoping to get as initial set (though not all) of the static
> properties still into 1.5. Using them to fix CPUID bugs can then be done
> during Hard Freeze. :)
patch "[PATCH 02/10] target-i386: cpu: convert existing dynamic properties
into static properties" should be enough for using model,level compat
properties.

>=20
> Andreas
>=20
> --=20
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg
>=20


--=20
Regards,
  Igor