From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58435) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWlLG-0005Mg-Qr for qemu-devel@nongnu.org; Mon, 29 Apr 2013 06:29:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWlLF-0004KO-Ja for qemu-devel@nongnu.org; Mon, 29 Apr 2013 06:29:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13958) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWlLF-0004K9-85 for qemu-devel@nongnu.org; Mon, 29 Apr 2013 06:29:53 -0400 Date: Mon, 29 Apr 2013 12:29:48 +0200 From: Igor Mammedov Message-ID: <20130429122948.41f3e03e@thinkpad> In-Reply-To: <1367148131-1440-1-git-send-email-afaerber@suse.de> References: <1367148131-1440-1-git-send-email-afaerber@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: anthony@codemonkey.ws, jan.kiszka@web.de, qemu-devel@nongnu.org, gleb@redhat.com, ehabkost@redhat.com On Sun, 28 Apr 2013 13:22:10 +0200 Andreas F=E4rber wrote: > Necessary to change the name of ICCDevice's parent object field. >=20 > Signed-off-by: Andreas F=E4rber > --- > Could any of the APIC experts please review whether I'm touching any hot= path? > Not sure if this was a mix of pre- and post-QOM code or intentional... T= hanks. >=20 > hw/i386/kvm/apic.c | 4 ++-- > hw/intc/apic.c | 20 +++++++++++--------- > hw/intc/apic_common.c | 10 +++++----- > include/hw/cpu/icc_bus.h | 2 +- > 4 files changed, 19 insertions(+), 17 deletions(-) >=20 [...] > =20 > diff --git a/include/hw/cpu/icc_bus.h b/include/hw/cpu/icc_bus.h > index b550070..f2c8a50 100644 > --- a/include/hw/cpu/icc_bus.h > +++ b/include/hw/cpu/icc_bus.h > @@ -51,7 +51,7 @@ typedef struct ICCBus { > */ > typedef struct ICCDevice { > /*< private >*/ > - DeviceState qdev; > + DeviceState parent_obj; This hunk doesn't apply to qpm-cpu-next. It looks like it's accidentally crept in=20 https://github.com/afaerber/qemu-cpu/commit/a7ae7cd073cc2b20de3372edc84ec5a= 01e88e55d > /*< public >*/ > } ICCDevice; > =20 > --=20 > 1.8.1.4 >=20 >=20 --=20 Regards, Igor