From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35050)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UWtOf-0006UA-Ra
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 15:05:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UWtOb-0004zK-VF
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 15:05:57 -0400
Received: from mx1.redhat.com ([209.132.183.28]:27371)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1UWtOb-0004yU-MY
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 15:05:53 -0400
Date: Mon, 29 Apr 2013 15:05:41 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130429150541.298db151@redhat.com>
In-Reply-To: <20130426144657.GB7648@stefanha-thinkpad.redhat.com>
References: <1366968675-1451-1-git-send-email-xiawenc@linux.vnet.ibm.com>
	<1366968675-1451-8-git-send-email-xiawenc@linux.vnet.ibm.com>
	<20130426144657.GB7648@stefanha-thinkpad.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 7/7] block: dump to monitor for
 bdrv_snapshot_dump() and bdrv_image_info_dump()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: kwolf@redhat.com, phrdina@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org, pbonzini@redhat.com, Wenchao Xia <xiawenc@linux.vnet.ibm.com>

On Fri, 26 Apr 2013 16:46:57 +0200
Stefan Hajnoczi <stefanha@gmail.com> wrote:

> On Fri, Apr 26, 2013 at 05:31:15PM +0800, Wenchao Xia wrote:
> > @@ -2586,10 +2585,12 @@ void do_info_snapshots(Monitor *mon, const QDict *qdict)
> >      }
> >  
> >      if (total > 0) {
> > -        monitor_printf(mon, "%s\n", bdrv_snapshot_dump(buf, sizeof(buf), NULL));
> > +        bdrv_snapshot_dump(NULL);
> > +        monitor_printf(mon, "\n");
> 
> Luiz: any issue with mixing monitor_printf(mon) and
> monitor_vprintf(cur_mon) calls?  I guess there was a reason for
> explicitly passing mon instead of relying on cur_mon.

where are they being mixed?