From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:35707)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1UWrpH-0001ux-2t
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:25:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1UWrpE-0003yL-Kr
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:25:19 -0400
Received: from mx1.redhat.com ([209.132.183.28]:56121)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jcody@redhat.com>) id 1UWrpE-0003yF-D3
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 13:25:16 -0400
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r3THPFuF006583
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Mon, 29 Apr 2013 13:25:15 -0400
Date: Mon, 29 Apr 2013 13:25:13 -0400
From: Jeff Cody <jcody@redhat.com>
Message-ID: <20130429172513.GE3525@localhost.localdomain>
References: <cover.1366726446.git.jcody@redhat.com>
	<56a0e0347fde5396fb6b2a260de5b1a867a588d6.1366726446.git.jcody@redhat.com>
	<20130428072914.GA27702@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20130428072914.GA27702@localhost.localdomain>
Subject: Re: [Qemu-devel] [PATCH v2 3/5] block: initial VHDX driver support
 framework - supports open and probe
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, kwolf@redhat.com, stefanha@redhat.com

On Sun, Apr 28, 2013 at 03:29:14PM +0800, Fam Zheng wrote:
> > +static void cpu_to_leguids(ms_guid *guid)
> > +{
> > +    cpu_to_le32s(&guid->data1);
> > +    cpu_to_le16s(&guid->data2);
> > +    cpu_to_le16s(&guid->data3);
> > +}
> 
> This one seems used in 5/5 only, so this patch fails compiling (defined
> but not used with -Werror=unused-function). Maybe move to 5/5?
>

Thanks.  Yes, that should be in patch 5 (git rebase user error there),
which means this will go away completely for v3.