From: Igor Mammedov <imammedo@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] target-arm: cpu: set default cpu_model via QEMUMachine.cpu_model
Date: Tue, 30 Apr 2013 17:01:44 +0200 [thread overview]
Message-ID: <20130430170144.3ad54345@nial.usersys.redhat.com> (raw)
In-Reply-To: <CAFEAcA8XZ03B6mb0-sxqb4AC_zW8wBOEV7b9mrWw=bUddQ5hfQ@mail.gmail.com>
On Tue, 30 Apr 2013 15:55:24 +0100
Peter Maydell <peter.maydell@linaro.org> wrote:
> On 30 April 2013 15:48, Igor Mammedov <imammedo@redhat.com> wrote:
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> > ---
> > compile tested only ...
> >
> > ---
> > hw/arm/realview.c | 16 ++++------------
> > hw/arm/versatilepb.c | 5 ++---
>
> Anything that's only touching these two boards is clearly
> not considering the whole situation -- more boards than
> just these two have a board specific default CPU.
that was only ones that used QEMUMachineArgs.cpu_model as storage for
dynamically setting default value.
Other machines should be checked and cleaned up as well.
perhaps commit subj should be:
target-arm: cpu: set default cpu_model via QEMUMachine.cpu_model for realview and versatilepb boards.
>
> thanks
> -- PMM
next prev parent reply other threads:[~2013-04-30 15:01 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 13:41 [Qemu-devel] [PATCH 0/5 v9 for-1.5] target-i386: CPU hot-add with cpu-add QMP command Igor Mammedov
2013-04-30 13:41 ` [Qemu-devel] [PATCH 1/5] add hot_add_cpu hook to QEMUMachine Igor Mammedov
2013-04-30 14:19 ` Eduardo Habkost
2013-04-30 15:48 ` Andreas Färber
2013-04-30 13:41 ` [Qemu-devel] [PATCH 2/5] QMP: add cpu-add command Igor Mammedov
2013-04-30 14:19 ` Eduardo Habkost
2013-04-30 15:58 ` Andreas Färber
2013-04-30 13:41 ` [Qemu-devel] [PATCH 3/5] add cpu_model to QEMUMachine Igor Mammedov
2013-04-30 14:30 ` Eduardo Habkost
2013-04-30 14:48 ` [Qemu-devel] [PATCH] target-arm: cpu: set default cpu_model via QEMUMachine.cpu_model Igor Mammedov
2013-04-30 14:55 ` Peter Maydell
2013-04-30 15:01 ` Igor Mammedov [this message]
2013-04-30 15:06 ` Eduardo Habkost
2013-04-30 14:54 ` [Qemu-devel] [PATCH 3/5] add cpu_model to QEMUMachine Peter Maydell
2013-04-30 15:14 ` Igor Mammedov
2013-04-30 15:32 ` Peter Maydell
2013-04-30 13:41 ` [Qemu-devel] [PATCH 4/5] target-i386: get default cpu_model from QEMUMachine Igor Mammedov
2013-04-30 14:47 ` Eduardo Habkost
2013-04-30 13:41 ` [Qemu-devel] [PATCH 5/5] target-i386: implement machine->hot_add_cpu hook Igor Mammedov
2013-04-30 16:00 ` Igor Mammedov
2013-04-30 16:31 ` Eduardo Habkost
2013-05-01 19:32 ` Andreas Färber
2013-05-02 7:18 ` Igor Mammedov
2013-05-02 11:46 ` Andreas Färber
2013-04-30 16:32 ` [Qemu-devel] [PATCH 5/5 v10] " Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430170144.3ad54345@nial.usersys.redhat.com \
--to=imammedo@redhat.com \
--cc=afaerber@suse.de \
--cc=ehabkost@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).