From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: peter.crosthwaite@xilinx.com
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH for-1.5 v3 00/15] Xilinx SPIPS fixes round 2
Date: Tue, 30 Apr 2013 20:12:03 +0200 [thread overview]
Message-ID: <20130430181203.GU4915@smtp.vpn> (raw)
In-Reply-To: <cover.1366606958.git.peter.crosthwaite@xilinx.com>
On Mon, Apr 22, 2013 at 03:11:19PM +1000, peter.crosthwaite@xilinx.com wrote:
> From: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>
> Updates to the Zynq SPI controller. Some QOMifying cleanup, followed by
> a number of bugs/incompletnesses found by some (very) rigourous test
> vectors.
Hi Peter,
The series looks good to me. Once you fix the build issues Peter Maydell
noticed, feel free to add my Reviewed-by tag.
Cheers,
Edgar
>
> changed from v3:
> Fixed break after goto (PMM review)
>
>
> Peter Crosthwaite (15):
> xilinx_spips: seperate SPI and QSPI as two classes
> xilinx_spips: Make interrupts clear on read
> xilinx_spips: Inhibit interrupts in LQSPI mode
> xilinx_spips: Add verbose LQSPI debug output
> xilinx_spips: Fix QSPI FIFO size
> xilinx_spips: Trash LQ page cache on mode change
> xilinx_spips: Add automatic start support
> xilinx_spips: Implement automatic CS
> xilinx_spips: lqspi: Dont touch config register
> xilinx_spips: Fix CTRL register RW bits
> xilinx_spips: Fix striping behaviour
> xilinx_spips: Debug msgs for Snoop state
> xilinx_spips: Multiple debug verbosity levels
> xilinx_spips: lqspi: Push more data to tx-fifo
> xilinx_spips: lqspi: Fix byte/misaligned access
>
> hw/arm/xilinx_zynq.c | 2 +-
> hw/ssi/xilinx_spips.c | 320 ++++++++++++++++++++++++++++++++++++++-----------
> 2 files changed, 249 insertions(+), 73 deletions(-)
>
prev parent reply other threads:[~2013-04-30 18:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-22 5:11 [Qemu-devel] [PATCH for-1.5 v3 00/15] Xilinx SPIPS fixes round 2 peter.crosthwaite
2013-04-22 5:11 ` [Qemu-devel] [PATCH for-1.5 v3 01/15] xilinx_spips: seperate SPI and QSPI as two classes peter.crosthwaite
2013-04-22 5:12 ` [Qemu-devel] [PATCH for-1.5 v3 02/15] xilinx_spips: Make interrupts clear on read peter.crosthwaite
2013-04-22 5:13 ` [Qemu-devel] [PATCH for-1.5 v3 03/15] xilinx_spips: Inhibit interrupts in LQSPI mode peter.crosthwaite
2013-04-22 5:13 ` [Qemu-devel] [PATCH for-1.5 v3 04/15] xilinx_spips: Add verbose LQSPI debug output peter.crosthwaite
2013-04-22 5:14 ` [Qemu-devel] [PATCH for-1.5 v3 05/15] xilinx_spips: Fix QSPI FIFO size peter.crosthwaite
2013-04-29 12:15 ` Peter Maydell
2013-04-22 5:15 ` [Qemu-devel] [PATCH for-1.5 v3 06/15] xilinx_spips: Trash LQ page cache on mode change peter.crosthwaite
2013-04-22 5:15 ` [Qemu-devel] [PATCH for-1.5 v3 07/15] xilinx_spips: Add automatic start support peter.crosthwaite
2013-04-22 5:16 ` [Qemu-devel] [PATCH for-1.5 v3 08/15] xilinx_spips: Implement automatic CS peter.crosthwaite
2013-04-29 12:14 ` Peter Maydell
2013-04-30 0:29 ` Peter Crosthwaite
2013-04-22 5:17 ` [Qemu-devel] [PATCH for-1.5 v3 09/15] xilinx_spips: lqspi: Dont touch config register peter.crosthwaite
2013-04-22 5:17 ` [Qemu-devel] [PATCH for-1.5 v3 10/15] xilinx_spips: Fix CTRL register RW bits peter.crosthwaite
2013-04-22 5:18 ` [Qemu-devel] [PATCH for-1.5 v3 11/15] xilinx_spips: Fix striping behaviour peter.crosthwaite
2013-04-22 5:19 ` [Qemu-devel] [PATCH for-1.5 v3 12/15] xilinx_spips: Debug msgs for Snoop state peter.crosthwaite
2013-04-22 5:19 ` [Qemu-devel] [PATCH for-1.5 v3 13/15] xilinx_spips: Multiple debug verbosity levels peter.crosthwaite
2013-04-22 5:20 ` [Qemu-devel] [PATCH for-1.5 v3 14/15] xilinx_spips: lqspi: Push more data to tx-fifo peter.crosthwaite
2013-04-22 5:21 ` [Qemu-devel] [PATCH for-1.5 v3 15/15] xilinx_spips: lqspi: Fix byte/misaligned access peter.crosthwaite
2013-04-30 18:12 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430181203.GU4915@smtp.vpn \
--to=edgar.iglesias@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).