* [Qemu-devel] [PATCH] qdev: Report errors collected during device realization
@ 2013-04-29 12:35 Jan Kiszka
2013-04-29 14:31 ` Andreas Färber
2013-04-30 18:58 ` Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Jan Kiszka @ 2013-04-29 12:35 UTC (permalink / raw)
To: qemu-devel, Andreas Färber; +Cc: Paolo Bonzini
Better than just releasing the error object silently.
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---
hw/core/qdev.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index 4eb0134..ab1d8f5 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -162,6 +162,7 @@ int qdev_init(DeviceState *dev)
object_property_set_bool(OBJECT(dev), true, "realized", &local_err);
if (local_err != NULL) {
+ qerror_report_err(local_err);
error_free(local_err);
qdev_free(dev);
return -1;
--
1.7.3.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qdev: Report errors collected during device realization
2013-04-29 12:35 [Qemu-devel] [PATCH] qdev: Report errors collected during device realization Jan Kiszka
@ 2013-04-29 14:31 ` Andreas Färber
2013-04-30 18:58 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Färber @ 2013-04-29 14:31 UTC (permalink / raw)
To: Jan Kiszka; +Cc: Paolo Bonzini, qemu-devel, Markus Armbruster, Luiz Capitulino
Am 29.04.2013 14:35, schrieb Jan Kiszka:
> Better than just releasing the error object silently.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
but CC'ing monitor guys to verify this is the right print function.
Andreas
> ---
> hw/core/qdev.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 4eb0134..ab1d8f5 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -162,6 +162,7 @@ int qdev_init(DeviceState *dev)
>
> object_property_set_bool(OBJECT(dev), true, "realized", &local_err);
> if (local_err != NULL) {
> + qerror_report_err(local_err);
> error_free(local_err);
> qdev_free(dev);
> return -1;
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] qdev: Report errors collected during device realization
2013-04-29 12:35 [Qemu-devel] [PATCH] qdev: Report errors collected during device realization Jan Kiszka
2013-04-29 14:31 ` Andreas Färber
@ 2013-04-30 18:58 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2013-04-30 18:58 UTC (permalink / raw)
To: Jan Kiszka, qemu-devel, None
Cc: Paolo Bonzini, Luiz Capitulino, Markus Armbruster
Applied. Thanks.
Regards,
Anthony Liguori
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-30 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-29 12:35 [Qemu-devel] [PATCH] qdev: Report errors collected during device realization Jan Kiszka
2013-04-29 14:31 ` Andreas Färber
2013-04-30 18:58 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).