From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXWNJ-0006vd-Pz for qemu-devel@nongnu.org; Wed, 01 May 2013 08:43:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXWNI-0005UG-97 for qemu-devel@nongnu.org; Wed, 01 May 2013 08:43:09 -0400 Received: from mail-bk0-x231.google.com ([2a00:1450:4008:c01::231]:51696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXWNI-0005U7-1v for qemu-devel@nongnu.org; Wed, 01 May 2013 08:43:08 -0400 Received: by mail-bk0-f49.google.com with SMTP id w5so620432bku.22 for ; Wed, 01 May 2013 05:43:07 -0700 (PDT) Date: Wed, 1 May 2013 14:43:04 +0200 From: Stefan Hajnoczi Message-ID: <20130501124304.GD28932@stefanha-thinkpad.redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v3 0/4] Initial VHDX support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jeff Cody Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Mon, Apr 29, 2013 at 02:48:15PM -0400, Jeff Cody wrote: > > Differences from v2: > > > Patch 2/4: changed 2 uint8_t[16] to MSGUID (Kevin) > renamed all strucs to proper style (Kevin) > indentations / style (Kevin) > Removed/fixed outdated comments (Stefan) > dropped vhdx_header_padded (Kevin) > > Patch 3/4: removed hunk that was meant for old patch 5/5 (Fam) > check VHDX header version field (Fam) > validate file type id in open and not just probe (Kevin) > allow headers with seq # of 0 if other header is invalid (Kevin) > fixed masking typo for parent meta present (Kevin) > removed error check for 512-byte sectors (Kevin) > verify region and metadata table guid are unique (Kevin) > removed signed/unsigned comparisons (Stefan) > sanity checking on rt.entry_count (Stefan) > use clz_() instead of inline code (Stefan) > bat_rt.length sanity check - compute it rather > than trust the entry length (Stefan) > > Patch 5 (v2): Dropped > > This adds the initial support for VHDX image files. > > It currently only supports read operations of VHDX, for fixed and dynamic files. > > Notably, the following is not yet supported: > * Differencing files > * Log replay (so we will refuse to open any images that are not 'clean') > * .bdrv_create() > * write operations other than to the header > > > Jeff Cody (4): > qemu: add castagnoli crc32c checksum algorithm > block: vhdx header for the QEMU support of VHDX images > block: initial VHDX driver support framework - supports open and probe > block: add read-only support to VHDX image format. > > block/Makefile.objs | 1 + > block/vhdx.c | 972 ++++++++++++++++++++++++++++++++++++++++++++++++++ > block/vhdx.h | 325 +++++++++++++++++ > include/qemu/crc32c.h | 35 ++ > util/Makefile.objs | 1 + > util/crc32c.c | 115 ++++++ > 6 files changed, 1449 insertions(+) > create mode 100644 block/vhdx.c > create mode 100644 block/vhdx.h > create mode 100644 include/qemu/crc32c.h > create mode 100644 util/crc32c.c Do you have links to vhdx files I can test? Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan