From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXZxv-0006s3-Im for qemu-devel@nongnu.org; Wed, 01 May 2013 12:33:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXZxs-0007is-7u for qemu-devel@nongnu.org; Wed, 01 May 2013 12:33:11 -0400 Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:50351) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXZxr-0007hN-UP for qemu-devel@nongnu.org; Wed, 01 May 2013 12:33:08 -0400 Date: Wed, 1 May 2013 18:32:30 +0200 From: Aurelien Jarno Message-ID: <20130501163230.GC4613@ohm.aurel32.net> References: <1367258703-6930-1-git-send-email-aliguori@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1367258703-6930-1-git-send-email-aliguori@us.ibm.com> Subject: Re: [Qemu-devel] [PATCH] softfloat: rebase to version 2a List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , Thiemo Seufer , Stefan Weil , Juan Quintela , Max Filippov , Richard Sandiford , Jocelyn Mayer , qemu-devel@nongnu.org, Blue Swirl , Christophe Lyon , Paul Brook , malc , Paolo Bonzini , Guan Xuetao , Andreas =?iso-8859-15?Q?F=E4rber?= , Richard Henderson , Avi Kivity On Mon, Apr 29, 2013 at 01:05:03PM -0500, Anthony Liguori wrote: > N.B. If you are on CC, see after the '---' for a requested action! > > The license of SoftFloat-2b is claimed to be GPLv2 incompatible by > the FSF due to an indemnification clause. The previous release, > SoftFloat-2a, did not contain this clause. The only changes between > these two versions as far as QEMU is concerned is the license change > and a global modification of the comment structure. This patch rebases > our softfloat code to SoftFloat-2a in order to have a GPLv2 compatible > license. Thanks for your work! > Please note, this is a comment-only change. The resulting binary should > be the same. > > I created this patch using the following strategy: > > 1) Create a branch using the original import of softfloat code: > $ git checkout 158142c2c2df728cfa3b5320c65534921a764f26 > > 2) Remove carriage returns from Softfloat-2b > > 3) Compare each of the softfloat files against Softfloat-2b using the > following mapping to generate Fabrice's original softfloat changes: > > - fpu/softfloat.c -> softfloat/bits64/softfloat.c > - fpu/softfloat.h -> softfloat/bits64/386-Win32-gcc/softfloat.h > - fpu/softfloat-macros.h -> softfloat/bits64/softfloat-macros > - fpu/softfloat-specialize.h -> softfloat/bits64/386-Win32-gcc/softfloat-specialize > > 4) Replace our softfloat files with the corresponding files from Softfloat-2a > > 5) Apply the diffs from (3) to (4) and commit > > 6) Create a diff between (5) and 158142c2c2df728cfa3b5320c65534921a764f26 > - This diff consists 100% of licensing change + comment reformating > > 7) Checkout the latest master branch, apply the diff from (6) > - There were a lot of comment rejects, confirmed this was only comments > and then used an emacs macro to rewrite the comments to the Softfloat-2a > form. I guess this last step is the reason why comments added long after the original code are also modified by your patch. Right? > Cc: Andreas Färber > Cc: Aurelien Jarno > Cc: Avi Kivity > Cc: Ben Taylor > Cc: Blue Swirl > Cc: Christophe Lyon > Cc: Fabrice Bellard > Cc: Guan Xuetao > Cc: Jocelyn Mayer > Cc: Juan Quintela > Cc: malc > Cc: Max Filippov > Cc: Paolo Bonzini > Cc: Paul Brook > Cc: Peter Maydell > Cc: Richard Henderson > Cc: Richard Sandiford > Cc: Stefan Weil > Cc: Thiemo Seufer > Signed-off-by: Anthony Liguori > --- > In order to make this change, we need to relicense all contributions > from initial import of the SoftFloat code to match the license of > SoftFloat-2a (instead of the implied SoftFloat-2b license). > > If you are on CC, it is because you have contributed to the softfloat > code in QEMU. Please response to this note with: > > Acked-by: Your Name > > To significant that you are able and willing to relicense your changes > to the SoftFloat-1a license (or a GPL compatible license). > > Please respond no later than May 6th, 2013. If we are unable to confirm > relicense from an author, changes from that author will be reverted. Acked-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net