qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu())
Date: Thu, 2 May 2013 17:17:04 +0300	[thread overview]
Message-ID: <20130502141704.GA12954@redhat.com> (raw)
In-Reply-To: <CAFEAcA_Jm8sgQnNMrrz5H1B1KAgrtiaDm3Br_qbfyFO_D-a+rA@mail.gmail.com>

On Thu, May 02, 2013 at 03:09:04PM +0100, Peter Maydell wrote:
> On 2 May 2013 14:51, Michael S. Tsirkin <mst@redhat.com> wrote:
> > As it is, patchwork is full of patches that were already reviewed and
> > merged, all my scripts that were filtering and sorting patches are also
> > useless, and I get to wade through each patch for the second time.
> 
> You need to fix patchwork to have some conception of a
> patch series. Then you can just select the whole series
> which is the pull request and say "ignore this" and you're
> done. Any patch-handling tool that doesn't let you operate
> at the level of a complete series is always going to mean
> you're doing huge amounts of busywork sometimes.

Sometimes I'm Cc'd on 1 patch out of series.
I might not want to go dig out the series only
to check if it actually needs review.

> I don't particularly object to suggesting that pullreq
> patches are all tagged 'PULL'; I don't think it's very
> likely that you'll get 100% consistency out of everybody
> though.
> 
> -- PMM

As there's one person that does the merges, it's pretty
easy to get consistency. If you are not
sending a patch for review it's just wrong to say PATCH
in a subject. Or should I now ignore everything that
doesn't explicitly say [PATCH pleasereview] ?

-- 
MST

  reply	other threads:[~2013-05-02 14:17 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-02 13:51 [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu()) Michael S. Tsirkin
2013-05-02 14:09 ` Peter Maydell
2013-05-02 14:17   ` Michael S. Tsirkin [this message]
2013-05-02 14:21     ` Peter Maydell
2013-05-02 14:22       ` Michael S. Tsirkin
2013-05-02 14:46       ` Gerd Hoffmann
2013-05-02 14:57         ` Peter Maydell
2013-05-02 15:59           ` Andreas Färber
2013-05-02 16:08             ` Peter Maydell
2013-05-02 16:11               ` Michael S. Tsirkin
2013-05-02 17:09               ` Andreas Färber
2013-05-02 18:15   ` Anthony Liguori
2013-05-02 15:01 ` Stefan Hajnoczi
2013-05-02 15:30 ` Paolo Bonzini
2013-05-02 15:33   ` Peter Maydell
2013-05-02 15:52     ` Anthony Liguori
2013-05-02 15:55       ` Peter Maydell
2013-05-02 16:06       ` Michael S. Tsirkin
2013-05-02 16:59         ` Paolo Bonzini
2013-05-02 18:19           ` Anthony Liguori
2013-05-03  0:15     ` Peter Crosthwaite

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130502141704.GA12954@redhat.com \
    --to=mst@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).