From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48237) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXv4Z-0008Cu-PU for qemu-devel@nongnu.org; Thu, 02 May 2013 11:05:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXv4X-0002VH-2W for qemu-devel@nongnu.org; Thu, 02 May 2013 11:05:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXv4W-0002VB-QI for qemu-devel@nongnu.org; Thu, 02 May 2013 11:05:25 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r42F5OK1008140 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 2 May 2013 11:05:24 -0400 Date: Thu, 2 May 2013 17:05:22 +0200 From: Stefan Hajnoczi Message-ID: <20130502150522.GB989@stefanha-thinkpad.redhat.com> References: <1367461527-9789-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1367461527-9789-1-git-send-email-famz@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5 0/6] vmdk: zeroed-grain GTE support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org On Thu, May 02, 2013 at 10:25:21AM +0800, Fam Zheng wrote: > Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1= ]. >=20 > [1] Virtual Disk Format 5.0 - VMware, > http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?s= rc=3Dvmdk >=20 > Changes since v4: > - 6/6: Correct endianess: *m_data->l2_cache_entry =3D offset; >=20 >=20 > Changes since v3: > - 5/6: Remove tmp > - 6/6: Update L2 Cache > Remove redundant assignment to m_data > Simplify l2_offset assignment to m_data > Fix m_data.offset endian. >=20 > Changes since v2: > - all: Added 5/6 (vmdk: store fields of VmdkMetaData in cpu endian) > - 6/6: Avoid side-effect of vmdk_L2update. > Change function comment to gtkdoc stype. > Fix VMDK4_FLAG_ZG. >=20 > Changes since v1: > - all: fix From: field > - 1/5: squash one line of ret code macro change from 2/5 > - 2/5: change VMDK4_FLAG_ZG to VMDK4_FLAG_ZERO_GRAIN > - 3/5: move BLOCK_OPT_ZEROED_GRAIN defination from block_int.h to vmdk= .c > - 5/5: fix metadata update issue, unit test with cases 033 034 >=20 > Fam Zheng (6): > vmdk: named return code. > vmdk: add support for =E2=80=9Czeroed=E2=80=90grain=E2=80=9D GTE > vmdk: Add option to create zeroed-grain image > vmdk: change magic number to macro > vmdk: store fields of VmdkMetaData in cpu endian > vmdk: add bdrv_co_write_zeroes >=20 > block/vmdk.c | 208 +++++++++++++++++++++++++++++++++++++++++----------= -------- > 1 file changed, 145 insertions(+), 63 deletions(-) Patches look fine now. The new option breaks qemu-iotests though: $ cd tests/qemu-iotests $ QEMU_PROG=3D$HOME/qemu/x86_64-softmmu/qemu-system-x86_64 \ PATH=3D$HOME/qemu:$PATH \ ./check -vmdk [...] 001 1s ... - output mismatch (see 001.out.bad) --- 001.out 2013-04-04 13:26:21.394050764 +0200 +++ 001.out.bad 2013-05-02 16:52:55.685803943 +0200 @@ -1,5 +1,5 @@ QA output created by 001 -Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728=20 +Formatting 'TEST_DIR/t.IMGFMT', fmt=3DIMGFMT size=3D134217728 zeroed_gr= ain=3Doff You'll need to filter out zeroed_grain from qemu-img output. We already do this for other options. Please send a patch to fix qemu-iotests so that I can apply this series. Thanks, Stefan