qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cornelia.huck@de.ibm.com>
To: fred.konrad@greensocs.com
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com,
	Michal Privoznik <mprivozn@redhat.com>,
	Libaiqing <libaiqing@huawei.com>,
	mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de,
	amit.shah@redhat.com, pbonzini@redhat.com, afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH for-1.5 v2 0/5] virtio: fix bus command line compatibility.
Date: Thu, 2 May 2013 15:40:07 +0200	[thread overview]
Message-ID: <20130502154007.03cc7989@gondolin> (raw)
In-Reply-To: <1367330931-12994-1-git-send-email-fred.konrad@greensocs.com>

On Tue, 30 Apr 2013 16:08:46 +0200
fred.konrad@greensocs.com wrote:

> From: KONRAD Frederic <fred.konrad@greensocs.com>
> 
> Cc: Libaiqing <libaiqing@huawei.com>
> Cc: Michal Privoznik <mprivozn@redhat.com>
> 
> This fixes the bus name for virtio-serial-device and virtio-scsi-device.
> 
> The bus name for virtio-serial-device and virtio-scsi-device is not "id.0" as it
> was the case before the refactoring.
> 
> This trigger the error:
> 
> qemu-system-xxx -device virtio-serial-pci,id=virtio-serial0
>                 -device virtserialport,bus=virtio-serial0.0
> 
> Bus 'virtio-serial0.0' is full
> Bus 'virtio-serial0.0' not found

Seems to look sane on s390-virtio and virtio-ccw.

Tested-by: Cornelia Huck <cornelia.huck@de.ibm.com>

> 
> So this sets the name of those bus before the virtio-device's init.
> 
> KONRAD Frederic (5):
>   virtio-x-bus: force bus name to virtio-bus.
>   virtio: add virtio_device_set_child_bus_name.
>   scsi: add bus_name parameter to scsi_bus_new.
>   virtio-serial: fix command line compatibility.
>   virtio-scsi: fix the command line compatibility.
> 
>  hw/char/virtio-serial-bus.c     |  3 ++-
>  hw/s390x/s390-virtio-bus.c      | 28 +++++++++++++++++++++++++++-
>  hw/s390x/virtio-ccw.c           | 28 +++++++++++++++++++++++++++-
>  hw/scsi/esp-pci.c               |  2 +-
>  hw/scsi/esp.c                   |  2 +-
>  hw/scsi/lsi53c895a.c            |  2 +-
>  hw/scsi/megasas.c               |  2 +-
>  hw/scsi/scsi-bus.c              |  5 +++--
>  hw/scsi/spapr_vscsi.c           |  2 +-
>  hw/scsi/virtio-scsi.c           |  3 ++-
>  hw/scsi/vmw_pvscsi.c            |  2 +-
>  hw/usb/dev-storage.c            |  4 ++--
>  hw/usb/dev-uas.c                |  2 +-
>  hw/virtio/virtio-pci.c          | 29 ++++++++++++++++++++++++++++-
>  hw/virtio/virtio.c              | 24 ++++++++++++++++++++++++
>  include/hw/scsi/scsi.h          |  3 ++-
>  include/hw/virtio/virtio-scsi.h |  1 -
>  include/hw/virtio/virtio.h      |  4 ++++
>  18 files changed, 128 insertions(+), 18 deletions(-)
> 

  parent reply	other threads:[~2013-05-02 13:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30 14:08 [Qemu-devel] [PATCH for-1.5 v2 0/5] virtio: fix bus command line compatibility fred.konrad
2013-04-30 14:08 ` [Qemu-devel] [PATCH for-1.5 v2 1/5] virtio-x-bus: force bus name to virtio-bus fred.konrad
2013-04-30 14:08 ` [Qemu-devel] [PATCH for-1.5 v2 2/5] virtio: add virtio_device_set_child_bus_name fred.konrad
2013-04-30 14:08 ` [Qemu-devel] [PATCH for-1.5 v2 3/5] scsi: add bus_name parameter to scsi_bus_new fred.konrad
2013-04-30 14:13   ` Paolo Bonzini
2013-04-30 14:08 ` [Qemu-devel] [PATCH for-1.5 v2 4/5] virtio-serial: fix command line compatibility fred.konrad
2013-04-30 14:08 ` [Qemu-devel] [PATCH for-1.5 v2 5/5] virtio-scsi: fix the " fred.konrad
2013-05-02 13:40 ` Cornelia Huck [this message]
2013-05-02 14:05   ` [Qemu-devel] [PATCH for-1.5 v2 0/5] virtio: fix bus " KONRAD Frédéric
2013-05-03 18:59 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130502154007.03cc7989@gondolin \
    --to=cornelia.huck@de.ibm.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=amit.shah@redhat.com \
    --cc=fred.konrad@greensocs.com \
    --cc=libaiqing@huawei.com \
    --cc=mark.burton@greensocs.com \
    --cc=mprivozn@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).