From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50374) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXtkH-0000wK-Ou for qemu-devel@nongnu.org; Thu, 02 May 2013 09:40:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXtk7-0006Ce-RC for qemu-devel@nongnu.org; Thu, 02 May 2013 09:40:25 -0400 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:45534) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXtk7-0006C6-GF for qemu-devel@nongnu.org; Thu, 02 May 2013 09:40:15 -0400 Received: from /spool/local by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 2 May 2013 14:37:11 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 925BE17D801D for ; Thu, 2 May 2013 14:41:12 +0100 (BST) Received: from d06av05.portsmouth.uk.ibm.com (d06av05.portsmouth.uk.ibm.com [9.149.37.229]) by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r42De04I46334012 for ; Thu, 2 May 2013 13:40:00 GMT Received: from d06av05.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av05.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r42De95G009985 for ; Thu, 2 May 2013 07:40:10 -0600 Date: Thu, 2 May 2013 15:40:07 +0200 From: Cornelia Huck Message-ID: <20130502154007.03cc7989@gondolin> In-Reply-To: <1367330931-12994-1-git-send-email-fred.konrad@greensocs.com> References: <1367330931-12994-1-git-send-email-fred.konrad@greensocs.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH for-1.5 v2 0/5] virtio: fix bus command line compatibility. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: fred.konrad@greensocs.com Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, Michal Privoznik , Libaiqing , mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, amit.shah@redhat.com, pbonzini@redhat.com, afaerber@suse.de On Tue, 30 Apr 2013 16:08:46 +0200 fred.konrad@greensocs.com wrote: > From: KONRAD Frederic > > Cc: Libaiqing > Cc: Michal Privoznik > > This fixes the bus name for virtio-serial-device and virtio-scsi-device. > > The bus name for virtio-serial-device and virtio-scsi-device is not "id.0" as it > was the case before the refactoring. > > This trigger the error: > > qemu-system-xxx -device virtio-serial-pci,id=virtio-serial0 > -device virtserialport,bus=virtio-serial0.0 > > Bus 'virtio-serial0.0' is full > Bus 'virtio-serial0.0' not found Seems to look sane on s390-virtio and virtio-ccw. Tested-by: Cornelia Huck > > So this sets the name of those bus before the virtio-device's init. > > KONRAD Frederic (5): > virtio-x-bus: force bus name to virtio-bus. > virtio: add virtio_device_set_child_bus_name. > scsi: add bus_name parameter to scsi_bus_new. > virtio-serial: fix command line compatibility. > virtio-scsi: fix the command line compatibility. > > hw/char/virtio-serial-bus.c | 3 ++- > hw/s390x/s390-virtio-bus.c | 28 +++++++++++++++++++++++++++- > hw/s390x/virtio-ccw.c | 28 +++++++++++++++++++++++++++- > hw/scsi/esp-pci.c | 2 +- > hw/scsi/esp.c | 2 +- > hw/scsi/lsi53c895a.c | 2 +- > hw/scsi/megasas.c | 2 +- > hw/scsi/scsi-bus.c | 5 +++-- > hw/scsi/spapr_vscsi.c | 2 +- > hw/scsi/virtio-scsi.c | 3 ++- > hw/scsi/vmw_pvscsi.c | 2 +- > hw/usb/dev-storage.c | 4 ++-- > hw/usb/dev-uas.c | 2 +- > hw/virtio/virtio-pci.c | 29 ++++++++++++++++++++++++++++- > hw/virtio/virtio.c | 24 ++++++++++++++++++++++++ > include/hw/scsi/scsi.h | 3 ++- > include/hw/virtio/virtio-scsi.h | 1 - > include/hw/virtio/virtio.h | 4 ++++ > 18 files changed, 128 insertions(+), 18 deletions(-) >