From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXw6N-0002O1-N8 for qemu-devel@nongnu.org; Thu, 02 May 2013 12:11:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXw6K-0008Nq-Qv for qemu-devel@nongnu.org; Thu, 02 May 2013 12:11:23 -0400 Received: from mx1.redhat.com ([209.132.183.28]:23548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXw6K-0008Nb-HB for qemu-devel@nongnu.org; Thu, 02 May 2013 12:11:20 -0400 Date: Thu, 2 May 2013 19:11:04 +0300 From: "Michael S. Tsirkin" Message-ID: <20130502161104.GB14776@redhat.com> References: <20130502135143.GA1171@redhat.com> <20130502141704.GA12954@redhat.com> <51827C37.403@redhat.com> <51828D58.5020103@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] posting patches in pull requests (was Re: [PATCH 08/29] cpu: Add qemu_for_each_cpu()) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: qemu-devel@nongnu.org, Andreas =?iso-8859-1?Q?F=E4rber?= , Anthony Liguori , Gerd Hoffmann On Thu, May 02, 2013 at 05:08:06PM +0100, Peter Maydell wrote: > On 2 May 2013 16:59, Andreas F=E4rber wrote: > > Am 02.05.2013 16:57, schrieb Peter Maydell: > >> Wow, you trust get_maintainer.pl that much? IME it > >> tends to give a huge pile of useless cc suggestions. > > > > Useless? It's based on MAINTAINERS, which I expect maintainers to kee= p > > up-to-date if they no longer want to maintain something. It's rather > > that new files don't get entries and thus too few CCs at times IME. >=20 > The ccs based on MAINTAINERS are fine -- it's the random > extras it picks based on other people who've made patches > to the same files in the past that are usually wrong. Just add --nogit then? > For example I tried running it on a patch to MAINTAINERS > itself, and it suggested ccing you, Alex, Stefan H, > Peter Crosthwaite and Edgar, which is a random mishmash > and doesn't include the key person you actually need > to CC, ie Anthony. >=20 > The actual rule as far as I can tell for CCs is "if > file is explicitly listed in MAINTAINERS, cc those people; > otherwise CC either Blue and Aurelien [if a random > target-* patch] or Anthony [everything else]; cc trivial > if sufficiently small; also for bugfixes CC whoever wrote > the commit you're fixing". get_maintainer.pl doesn't do > that, so I just write CCs manually. >=20 > thanks > -- PMM You could also try to make get_maintainer.pl do what you want. Well maybe beside trivial.