From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33387) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYC5L-0002ol-KJ for qemu-devel@nongnu.org; Fri, 03 May 2013 05:15:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYC58-0002cQ-Au for qemu-devel@nongnu.org; Fri, 03 May 2013 05:15:23 -0400 Received: from mail-wg0-x230.google.com ([2a00:1450:400c:c00::230]:32869) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYC57-0002cJ-Vf for qemu-devel@nongnu.org; Fri, 03 May 2013 05:15:10 -0400 Received: by mail-wg0-f48.google.com with SMTP id f11so1385422wgh.27 for ; Fri, 03 May 2013 02:15:09 -0700 (PDT) Date: Fri, 3 May 2013 11:15:06 +0200 From: Stefan Hajnoczi Message-ID: <20130503091506.GB21226@stefanha-thinkpad.redhat.com> References: <1367461527-9789-1-git-send-email-famz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1367461527-9789-1-git-send-email-famz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5 0/6] vmdk: zeroed-grain GTE support List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Thu, May 02, 2013 at 10:25:21AM +0800, Fam Zheng wrote: > Added support for zeroed-grain GTE to VMDK according to VMDK Spec 5.0[1]. > > [1] Virtual Disk Format 5.0 - VMware, > http://www.vmware.com/support/developer/vddk/vmdk_50_technote.pdf?src=vmdk > > Changes since v4: > - 6/6: Correct endianess: *m_data->l2_cache_entry = offset; > > > Changes since v3: > - 5/6: Remove tmp > - 6/6: Update L2 Cache > Remove redundant assignment to m_data > Simplify l2_offset assignment to m_data > Fix m_data.offset endian. > > Changes since v2: > - all: Added 5/6 (vmdk: store fields of VmdkMetaData in cpu endian) > - 6/6: Avoid side-effect of vmdk_L2update. > Change function comment to gtkdoc stype. > Fix VMDK4_FLAG_ZG. > > Changes since v1: > - all: fix From: field > - 1/5: squash one line of ret code macro change from 2/5 > - 2/5: change VMDK4_FLAG_ZG to VMDK4_FLAG_ZERO_GRAIN > - 3/5: move BLOCK_OPT_ZEROED_GRAIN defination from block_int.h to vmdk.c > - 5/5: fix metadata update issue, unit test with cases 033 034 > > Fam Zheng (6): > vmdk: named return code. > vmdk: add support for “zeroed‐grain” GTE > vmdk: Add option to create zeroed-grain image > vmdk: change magic number to macro > vmdk: store fields of VmdkMetaData in cpu endian > vmdk: add bdrv_co_write_zeroes > > block/vmdk.c | 208 +++++++++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 145 insertions(+), 63 deletions(-) > > -- > 1.8.1.4 > > Thanks, applied to my block tree: https://github.com/stefanha/qemu/commits/block Stefan