From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60380) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYE05-000781-O0 for qemu-devel@nongnu.org; Fri, 03 May 2013 07:18:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYE04-0006Rc-Bu for qemu-devel@nongnu.org; Fri, 03 May 2013 07:18:05 -0400 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:50589) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYE04-0006Qo-11 for qemu-devel@nongnu.org; Fri, 03 May 2013 07:18:04 -0400 Received: by mail-wi0-f173.google.com with SMTP id ey16so494655wid.0 for ; Fri, 03 May 2013 04:18:03 -0700 (PDT) Date: Fri, 3 May 2013 13:17:59 +0200 From: Stefan Hajnoczi Message-ID: <20130503111759.GA2471@stefanha-thinkpad.redhat.com> References: <1367461606-7554-1-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1367461606-7554-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V4 0/5] block: make qmp_transaction extendable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, pbonzini@redhat.com, qemu-devel@nongnu.org, dietmar@proxmox.com On Thu, May 02, 2013 at 10:26:41AM +0800, Wenchao Xia wrote: > This serial will package backing chain snapshot code as one case, to make it > possible adding more operations later. > > v2: > Address Kevin's comments: > Use the same prototype prepare, commit, rollback model in original code, > commit should never fail. > > v3: > Address Stefan's comments: > 3/5, 4/5: remove *action parameter since later only BlkTransactionStates* is > needed. > 5/5: embbed BlkTransactionStates in ExternalSnapshotStates, *opaque is > removed, related call back function format change for external snapshot. > Address Kevin's comments: > removed all indention in commit message. > 1/5: return void for prepare() function, *errp plays the role as error > checker. > 5/5: mark *commit callback must exist, *rollback callback can be NULL. Align > "callback =" in "const BdrvActionOps external_snapshot_ops" to the same colum. > Address Eric's comments: > 1/5: better commit message. > 5/5: better commit message and comments in code that only one of rollback() > or commit() will be called. > > v4: > 5/5: document clean() callback will always be called if it present, declare > static for global variable "actions", use array plus .instance_size to remove > "switch" checking code according to caller input. > > Wenchao Xia (5): > 1 block: package preparation code in qmp_transaction() > 2 block: move input parsing code in qmp_transaction() > 3 block: package committing code in qmp_transaction() > 4 block: package rollback code in qmp_transaction() > 5 block: make all steps in qmp_transaction() as callback > > blockdev.c | 263 ++++++++++++++++++++++++++++++++++++++--------------------- > 1 files changed, 169 insertions(+), 94 deletions(-) Good for QEMU 1.6. Reviewed-by: Stefan Hajnoczi