From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60533) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYJWb-0000Vw-Uu for qemu-devel@nongnu.org; Fri, 03 May 2013 13:12:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UYJWa-00037Z-PG for qemu-devel@nongnu.org; Fri, 03 May 2013 13:12:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:22019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UYJWa-00037S-G8 for qemu-devel@nongnu.org; Fri, 03 May 2013 13:12:00 -0400 Date: Fri, 3 May 2013 19:11:49 +0200 From: Igor Mammedov Message-ID: <20130503191149.67804d3b@thinkpad> In-Reply-To: <87sj24ko3g.fsf@codemonkey.ws> References: <1367424440-16687-1-git-send-email-afaerber@suse.de> <87sj24ko3g.fsf@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu for-1.5 0/4] target-i386: X86CPU compatibility properties List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: ehabkost@redhat.com, "Michael S. Tsirkin" , qemu-devel@nongnu.org, "H. Peter Anvin" , pbonzini@redhat.com, Borislav Petkov , Andreas =?ISO-8859-1?B?RuRyYmVy?= On Fri, 03 May 2013 11:46:59 -0500 Anthony Liguori wrote: > Andreas F=E4rber writes: >=20 > > Hello, > > > > It's easier adapting the infrastructure to our needs than working aroun= d it: > > X86CPU already has QOM properties today. What's lacking is model subcla= sses, > > and with the one X86CPU type its global properties are overwritten by m= odels. > > But we already know the designated naming scheme for the models! > > > > So let's simply prepare compat_props for CPU models and make sure they = are > > already picked up today. > > > > This works just fine for changing the 486 CPUID model value and avoids = to > > redo the PC part once we have X86CPU subclasses. > > Tested using: ./QMP/qom-get /machine/icc-bridge/icc/child[0].model >=20 > So, what's left to do with subclass modelling? I plan to resubmit static properties and then subclass modeling for 1.6. >=20 > How long are we going to need to carry something like this? It will be removed with x86 CPU static properties and CPU sub-classes. >=20 > It's a clever work around but I'm a bit concerned that it would grow > beyond cpu subclasses and that we'd be stuck with it forever. >=20 > Regards, >=20 > Anthony Liguori >=20 > > > > For changing n270 CPUID flags we'll still need to resort to Eduardo's p= roposed > > helper functions for now. > > > > Regards, > > Andreas > > > > Cc: Eduardo Habkost > > Cc: Igor Mammedov > > Cc: H. Peter Anvin > > Cc: Borislav Petkov > > Cc: Anthony Liguori > > Cc: Paolo Bonzini > > Cc: Michael S. Tsirkin > > > > Andreas F=E4rber (4): > > qdev: Let qdev_prop_parse() pass through Error > > qdev: Introduce qdev_prop_set_custom_globals() > > target-i386: Emulate X86CPU subclasses for global properties > > target-i386: Change CPUID model of 486 to 8 > > > > hw/core/qdev-properties.c | 50 ++++++++++++++++++++++++++----------= -------- > > hw/core/qdev.c | 7 ++++++- > > include/hw/i386/pc.h | 4 ++++ > > include/hw/qdev-properties.h | 7 +++++-- > > qdev-monitor.c | 6 +++++- > > target-i386/cpu.c | 11 +++++++++- > > 6 files changed, 60 insertions(+), 25 deletions(-) > > > > --=20 > > 1.8.1.4 --=20 Regards, Igor