From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZNmD-0006ON-2y for qemu-devel@nongnu.org; Mon, 06 May 2013 11:56:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZNm8-00044K-Es for qemu-devel@nongnu.org; Mon, 06 May 2013 11:56:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12275) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZNm8-000446-6C for qemu-devel@nongnu.org; Mon, 06 May 2013 11:56:28 -0400 Date: Mon, 6 May 2013 11:56:14 -0400 From: Luiz Capitulino Message-ID: <20130506115614.36a4ec6a@redhat.com> In-Reply-To: <20130503111759.GA2471@stefanha-thinkpad.redhat.com> References: <1367461606-7554-1-git-send-email-xiawenc@linux.vnet.ibm.com> <20130503111759.GA2471@stefanha-thinkpad.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V4 0/5] block: make qmp_transaction extendable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: kwolf@redhat.com, pbonzini@redhat.com, Wenchao Xia , dietmar@proxmox.com, qemu-devel@nongnu.org On Fri, 3 May 2013 13:17:59 +0200 Stefan Hajnoczi wrote: > On Thu, May 02, 2013 at 10:26:41AM +0800, Wenchao Xia wrote: > > This serial will package backing chain snapshot code as one case, to make it > > possible adding more operations later. > > > > v2: > > Address Kevin's comments: > > Use the same prototype prepare, commit, rollback model in original code, > > commit should never fail. > > > > v3: > > Address Stefan's comments: > > 3/5, 4/5: remove *action parameter since later only BlkTransactionStates* is > > needed. > > 5/5: embbed BlkTransactionStates in ExternalSnapshotStates, *opaque is > > removed, related call back function format change for external snapshot. > > Address Kevin's comments: > > removed all indention in commit message. > > 1/5: return void for prepare() function, *errp plays the role as error > > checker. > > 5/5: mark *commit callback must exist, *rollback callback can be NULL. Align > > "callback =" in "const BdrvActionOps external_snapshot_ops" to the same colum. > > Address Eric's comments: > > 1/5: better commit message. > > 5/5: better commit message and comments in code that only one of rollback() > > or commit() will be called. > > > > v4: > > 5/5: document clean() callback will always be called if it present, declare > > static for global variable "actions", use array plus .instance_size to remove > > "switch" checking code according to caller input. > > > > Wenchao Xia (5): > > 1 block: package preparation code in qmp_transaction() > > 2 block: move input parsing code in qmp_transaction() > > 3 block: package committing code in qmp_transaction() > > 4 block: package rollback code in qmp_transaction() > > 5 block: make all steps in qmp_transaction() as callback > > > > blockdev.c | 263 ++++++++++++++++++++++++++++++++++++++--------------------- > > 1 files changed, 169 insertions(+), 94 deletions(-) > > Good for QEMU 1.6. > > Reviewed-by: Stefan Hajnoczi Looks good to me too. Are you going to apply v5 to the block branch?