From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZRxZ-0007NP-KQ for qemu-devel@nongnu.org; Mon, 06 May 2013 16:24:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZRxU-00075T-Sz for qemu-devel@nongnu.org; Mon, 06 May 2013 16:24:33 -0400 Date: Mon, 6 May 2013 22:24:15 +0200 From: Aurelien Jarno Message-ID: <20130506202415.GL5000@ohm.aurel32.net> References: <1367862787-12248-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <1367862787-12248-1-git-send-email-agraf@suse.de> Subject: Re: [Qemu-devel] [PATCH] PPC: Fix rldcl List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org, tg@gmplib.org On Mon, May 06, 2013 at 07:53:07PM +0200, Alexander Graf wrote: > The implementation for rldcl tried to always fetch its > parameters from the opcode, even though the opcode was > already passed in in decoded and different forms. > > Use the parameters instead, fixing rldcl. > > Reported-by: Torbjorn Granlund > Signed-off-by: Alexander Graf > --- > target-ppc/translate.c | 2 -- > 1 files changed, 0 insertions(+), 2 deletions(-) > > diff --git a/target-ppc/translate.c b/target-ppc/translate.c > index 0886f4d..a018616 100644 > --- a/target-ppc/translate.c > +++ b/target-ppc/translate.c > @@ -1733,8 +1733,6 @@ static inline void gen_rldnm(DisasContext *ctx, uint32_t mb, uint32_t me) > { > TCGv t0; > > - mb = MB(ctx->opcode); > - me = ME(ctx->opcode); > t0 = tcg_temp_new(); > tcg_gen_andi_tl(t0, cpu_gpr[rB(ctx->opcode)], 0x3f); > tcg_gen_rotl_tl(t0, cpu_gpr[rS(ctx->opcode)], t0); Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net