* [Qemu-devel] [PATCH] PPC: Fix rldcl
@ 2013-05-06 17:53 Alexander Graf
2013-05-06 20:24 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Graf @ 2013-05-06 17:53 UTC (permalink / raw)
To: qemu-ppc; +Cc: qemu-devel, tg
The implementation for rldcl tried to always fetch its
parameters from the opcode, even though the opcode was
already passed in in decoded and different forms.
Use the parameters instead, fixing rldcl.
Reported-by: Torbjorn Granlund <tg@gmplib.org>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
target-ppc/translate.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/target-ppc/translate.c b/target-ppc/translate.c
index 0886f4d..a018616 100644
--- a/target-ppc/translate.c
+++ b/target-ppc/translate.c
@@ -1733,8 +1733,6 @@ static inline void gen_rldnm(DisasContext *ctx, uint32_t mb, uint32_t me)
{
TCGv t0;
- mb = MB(ctx->opcode);
- me = ME(ctx->opcode);
t0 = tcg_temp_new();
tcg_gen_andi_tl(t0, cpu_gpr[rB(ctx->opcode)], 0x3f);
tcg_gen_rotl_tl(t0, cpu_gpr[rS(ctx->opcode)], t0);
--
1.6.0.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] PPC: Fix rldcl
2013-05-06 17:53 [Qemu-devel] [PATCH] PPC: Fix rldcl Alexander Graf
@ 2013-05-06 20:24 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2013-05-06 20:24 UTC (permalink / raw)
To: Alexander Graf; +Cc: qemu-ppc, qemu-devel, tg
On Mon, May 06, 2013 at 07:53:07PM +0200, Alexander Graf wrote:
> The implementation for rldcl tried to always fetch its
> parameters from the opcode, even though the opcode was
> already passed in in decoded and different forms.
>
> Use the parameters instead, fixing rldcl.
>
> Reported-by: Torbjorn Granlund <tg@gmplib.org>
> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
> target-ppc/translate.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/target-ppc/translate.c b/target-ppc/translate.c
> index 0886f4d..a018616 100644
> --- a/target-ppc/translate.c
> +++ b/target-ppc/translate.c
> @@ -1733,8 +1733,6 @@ static inline void gen_rldnm(DisasContext *ctx, uint32_t mb, uint32_t me)
> {
> TCGv t0;
>
> - mb = MB(ctx->opcode);
> - me = ME(ctx->opcode);
> t0 = tcg_temp_new();
> tcg_gen_andi_tl(t0, cpu_gpr[rB(ctx->opcode)], 0x3f);
> tcg_gen_rotl_tl(t0, cpu_gpr[rS(ctx->opcode)], t0);
Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-06 20:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-06 17:53 [Qemu-devel] [PATCH] PPC: Fix rldcl Alexander Graf
2013-05-06 20:24 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).