From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45957) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZjSv-00074j-O1 for qemu-devel@nongnu.org; Tue, 07 May 2013 11:06:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UZjSp-0008I0-36 for qemu-devel@nongnu.org; Tue, 07 May 2013 11:06:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11891) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UZjSo-0008Ho-Rn for qemu-devel@nongnu.org; Tue, 07 May 2013 11:05:59 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r47F5wAF015893 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 7 May 2013 11:05:58 -0400 Date: Tue, 7 May 2013 18:05:51 +0300 From: "Michael S. Tsirkin" Message-ID: <20130507150551.GA23608@redhat.com> References: <1367933676-21854-1-git-send-email-kraxel@redhat.com> <1367933676-21854-6-git-send-email-kraxel@redhat.com> <20130507140601.GB22422@redhat.com> <51890C29.7020409@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51890C29.7020409@redhat.com> Subject: Re: [Qemu-devel] [PATCH 5/6] xhci: add vmstate List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Tue, May 07, 2013 at 04:14:01PM +0200, Gerd Hoffmann wrote: > On 05/07/13 16:06, Michael S. Tsirkin wrote: > >> +#if 0 > > should have a comment explaining why is this > > commented out. > > Or just drop this section. > > > >> > + /* event queue (used if ring is full) */ > >> > + VMSTATE_BOOL(er_full, XHCIInterrupter), > >> > + VMSTATE_UINT32(ev_buffer_put, XHCIInterrupter), > >> > + VMSTATE_UINT32(ev_buffer_get, XHCIInterrupter), > >> > + /* TODO */ XHCIEvent ev_buffer[EV_QUEUE]; > >> > +#endif > >> > > > xhci buffers events in case the ring is full. Doesn't happen under > normal circumstances, thats why I didn't bother finishing it (yet). > > Doing that and stress-testing xhci migration are the todo list items > before I'll go merge this series. > > cheers, > Gerd 'PATCH notformerge' or something like this in the subj would be helpful, in the future. -- MST