From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Igor Mammedov <imammedo@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, Eduardo Habkost <ehabkost@redhat.com>,
Kazuya Saito <saito.kazuya@jp.fujitsu.com>
Subject: Re: [Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints
Date: Wed, 8 May 2013 10:48:51 +0200 [thread overview]
Message-ID: <20130508084851.GD16581@stefanha-thinkpad.muc.redhat.com> (raw)
In-Reply-To: <5183A99E.1080801@suse.de>
On Fri, May 03, 2013 at 02:12:14PM +0200, Andreas Färber wrote:
> > +# kvm-all.c
> > +kvm_ioctl(int type, void *arg) "type %d, arg %p"
> > +kvm_vm_ioctl(int type, void *arg) "type %d, arg %p"
> > +kvm_vcpu_ioctl(int cpu_index, int type, void *arg) "cpu_index %d, type %d, arg %p"
>
> Sorry that I'm just seeing this patch now (wasn't CC'ed), but I wonder
> whether cpu_index is the best thing to trace here? Can we still change
> trace event API or would we have to nack/change now?
Trace events are not stable. We can change them.
STefan
next prev parent reply other threads:[~2013-05-08 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-03 12:01 [Qemu-devel] [PULL 0/4] Tracing patches Stefan Hajnoczi
2013-05-03 12:01 ` [Qemu-devel] [PATCH 1/4] kvm-all: add kvm_ioctl, kvm_vm_ioctl, kvm_vcpu_ioctl tracepoints Stefan Hajnoczi
2013-05-03 12:12 ` Andreas Färber
2013-05-03 13:31 ` Eduardo Habkost
2013-05-08 8:48 ` Stefan Hajnoczi [this message]
2013-05-03 12:01 ` [Qemu-devel] [PATCH 2/4] kvm-all: add kvm_run_exit tracepoint Stefan Hajnoczi
2013-05-03 12:01 ` [Qemu-devel] [PATCH 3/4] trace: Add ftrace tracing backend Stefan Hajnoczi
2013-05-03 12:01 ` [Qemu-devel] [PATCH 4/4] trace: document ftrace backend Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508084851.GD16581@stefanha-thinkpad.muc.redhat.com \
--to=stefanha@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@us.ibm.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=saito.kazuya@jp.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).