From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48366) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua2Qp-0003VS-Eb for qemu-devel@nongnu.org; Wed, 08 May 2013 07:21:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ua2Qo-00043l-82 for qemu-devel@nongnu.org; Wed, 08 May 2013 07:21:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ua2Qn-00043h-VU for qemu-devel@nongnu.org; Wed, 08 May 2013 07:21:10 -0400 Date: Wed, 8 May 2013 13:21:04 +0200 From: Kevin Wolf Message-ID: <20130508112104.GF3093@dhcp-200-207.str.redhat.com> References: <1368008716-9632-1-git-send-email-xiawenc@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1368008716-9632-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [PATCH V5 0/5] block: make qmp_transaction extendable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: pbonzini@redhat.com, qemu-devel@nongnu.org, dietmar@proxmox.com, stefanha@gmail.com Am 08.05.2013 um 12:25 hat Wenchao Xia geschrieben: > This serial will package backing chain snapshot code as one case, to make it > possible adding more operations later. > > v2: > Address Kevin's comments: > Use the same prototype prepare, commit, rollback model in original code, > commit should never fail. > > v3: > Address Stefan's comments: > 3/5, 4/5: remove *action parameter since later only BlkTransactionStates* is > needed. > 5/5: embbed BlkTransactionStates in ExternalSnapshotStates, *opaque is > removed, related call back function format change for external snapshot. > Address Kevin's comments: > removed all indention in commit message. > 1/5: return void for prepare() function, *errp plays the role as error > checker. > 5/5: mark *commit callback must exist, *rollback callback can be NULL. Align > "callback =" in "const BdrvActionOps external_snapshot_ops" to the same colum. > Address Eric's comments: > 1/5: better commit message. > 5/5: better commit message and comments in code that only one of rollback() > or commit() will be called. > > v4: > 5/5: document clean() callback will always be called if it present, declare > static for global variable "actions", use array plus .instance_size to remove > "switch" checking code according to caller input. > > v5: > better commit message and comments, switch callback function name "rollback" > to "abort". > > Wenchao Xia (5): > 1 block: package preparation code in qmp_transaction() > 2 block: move input parsing code in qmp_transaction() > 3 block: package committing code in qmp_transaction() > 4 block: package rollback code in qmp_transaction() > 5 block: make all steps in qmp_transaction() as callback > > blockdev.c | 266 ++++++++++++++++++++++++++++++++++++++---------------------- > 1 files changed, 169 insertions(+), 97 deletions(-) Thanks, applied all to block-next for 1.6. Kevin