From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, Wenchao Xia <xiawenc@linux.vnet.ibm.com>,
imain@redhat.com, pbonzini@redhat.com, dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command
Date: Wed, 8 May 2013 14:49:00 +0200 [thread overview]
Message-ID: <20130508124859.GH3093@dhcp-200-207.str.redhat.com> (raw)
In-Reply-To: <1367221335-22777-3-git-send-email-stefanha@redhat.com>
Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben:
> @block-backup
>
> Start a point-in-time copy of a block device to a new destination. The
> status of ongoing block backup operations can be checked with
> query-block-jobs. The operation can be stopped before it has completed using
> the block-job-cancel command.
>
> @device: the name of the device whose writes should be mirrored.
>
> @target: the target of the new image. If the file exists, or if it
> is a device, the existing file/device will be used as the new
> destination. If it does not exist, a new file will be created.
>
> @format: #optional the format of the new destination, default is to
> probe if @mode is 'existing', else the format of the source
>
> @mode: #optional whether and how QEMU should create a new image, default is
> 'absolute-paths'.
>
> @speed: #optional the maximum speed, in bytes per second
>
> Returns: nothing on success
> If @device is not a valid block device, DeviceNotFound
>
> Since 1.6
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
drive-backup would probably be a more consistent naming. We would then
still have block-backup for a future low-level command that doesn't
create everything by itself but takes an existing BlockDriverState (e.g.
created by blockdev-add).
We should also make it transactionable from the beginning, as we don't
have schema introspection yet. This way we allow to assume that if the
standalone command exists, the transaction subcommand exists as well.
Kevin
next prev parent reply other threads:[~2013-05-08 13:38 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 7:42 [Qemu-devel] [PATCH v2 0/3] block: block-backup live backup command Stefan Hajnoczi
2013-04-29 7:42 ` [Qemu-devel] [PATCH v2 1/3] block: add basic backup support to block driver Stefan Hajnoczi
2013-05-08 12:39 ` Kevin Wolf
2013-05-08 15:43 ` Paolo Bonzini
2013-05-14 8:51 ` Stefan Hajnoczi
2013-05-14 13:24 ` Stefan Hajnoczi
2013-05-14 13:43 ` Kevin Wolf
2013-05-14 15:12 ` Stefan Hajnoczi
2013-05-30 3:37 ` Fam Zheng
2013-05-30 12:27 ` Stefan Hajnoczi
2013-04-29 7:42 ` [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command Stefan Hajnoczi
2013-05-08 12:49 ` Kevin Wolf [this message]
2013-05-11 3:34 ` Eric Blake
2013-05-11 8:02 ` Paolo Bonzini
2013-05-13 8:23 ` Kevin Wolf
2013-05-14 8:44 ` Stefan Hajnoczi
2013-05-11 4:02 ` Eric Blake
2013-05-13 8:28 ` Kevin Wolf
2013-05-13 12:56 ` Eric Blake
2013-05-13 13:09 ` Kevin Wolf
2013-05-13 13:18 ` Luiz Capitulino
2013-05-13 14:14 ` Eric Blake
2013-05-13 14:27 ` Kevin Wolf
2013-05-13 14:50 ` Eric Blake
2013-05-14 2:18 ` Wenchao Xia
2013-05-14 8:48 ` Stefan Hajnoczi
2013-04-29 7:42 ` [Qemu-devel] [PATCH v2 3/3] qemu-iotests: add 054 block-backup test case Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508124859.GH3093@dhcp-200-207.str.redhat.com \
--to=kwolf@redhat.com \
--cc=dietmar@proxmox.com \
--cc=famz@redhat.com \
--cc=imain@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=xiawenc@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).