Re: [Qemu-devel] [PATCH] curl: fix curl read

[Stefan Hajnoczi <stefanha@gmail.com>]

On Fri, May 03, 2013 at 07:23:31PM +0800, Fam Zheng wrote:
> On Fri, 05/03 13:09, Stefan Hajnoczi wrote:
> > On Fri, May 03, 2013 at 04:00:09PM +0800, Fam Zheng wrote:
> > > CURL library API has changed, the current curl driver is not working.
> > > This patch rewrites the use of API as well as the structure of internal
> > > states. (It is hard to split this to multiple patches as basically all
> > > these changes need to work together.)
> > 
> > Which libcurl APIs have changed?  I expect libcurl to be backwards
> > compatible.
> 
> Function curl_multi_socket_all (see man 3 curl_multi_socket) is
> deprecated, and not working as I tried the current curl driver, build
> against libcurl 7.27.0. It's deprecated to be replaced by
> curl_multi_socket_action.
> 
> The version does not concern, they are all introduced in the same
> version, 7.15.4 [1], and has been there for long.
> 
> [1]: http://curl.haxx.se/libcurl/c/curl_multi_socket_action.html

Great, please include the details in the commit description.

I checked that RHEL 5.x has libcurl 7.15.5 so it should be safe to use
curl_multi_socket_action().  Most other operating systems will have a
newer libcurl than this.

Stefan