From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaJhR-0006RD-52 for qemu-devel@nongnu.org; Thu, 09 May 2013 01:47:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UaJhP-0000NG-Ff for qemu-devel@nongnu.org; Thu, 09 May 2013 01:47:29 -0400 Received: from mail-wg0-x235.google.com ([2a00:1450:400c:c00::235]:37839) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UaJhP-0000N3-8F for qemu-devel@nongnu.org; Thu, 09 May 2013 01:47:27 -0400 Received: by mail-wg0-f53.google.com with SMTP id y10so2667628wgg.20 for ; Wed, 08 May 2013 22:47:26 -0700 (PDT) Date: Thu, 9 May 2013 07:47:23 +0200 From: Stefan Hajnoczi Message-ID: <20130509054723.GA1074@stefanha-thinkpad.redhat.com> References: <1367568009-4900-1-git-send-email-famz@redhat.com> <20130503110916.GB1535@stefanha-thinkpad.redhat.com> <20130503112331.GA4517@fam-laptop.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130503112331.GA4517@fam-laptop.nay.redhat.com> Subject: Re: [Qemu-devel] [PATCH] curl: fix curl read List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi , qemu-devel@nongnu.org, kwolf@redhat.com On Fri, May 03, 2013 at 07:23:31PM +0800, Fam Zheng wrote: > On Fri, 05/03 13:09, Stefan Hajnoczi wrote: > > On Fri, May 03, 2013 at 04:00:09PM +0800, Fam Zheng wrote: > > > CURL library API has changed, the current curl driver is not working. > > > This patch rewrites the use of API as well as the structure of internal > > > states. (It is hard to split this to multiple patches as basically all > > > these changes need to work together.) > > > > Which libcurl APIs have changed? I expect libcurl to be backwards > > compatible. > > Function curl_multi_socket_all (see man 3 curl_multi_socket) is > deprecated, and not working as I tried the current curl driver, build > against libcurl 7.27.0. It's deprecated to be replaced by > curl_multi_socket_action. > > The version does not concern, they are all introduced in the same > version, 7.15.4 [1], and has been there for long. > > [1]: http://curl.haxx.se/libcurl/c/curl_multi_socket_action.html Great, please include the details in the commit description. I checked that RHEL 5.x has libcurl 7.15.5 so it should be safe to use curl_multi_socket_action(). Most other operating systems will have a newer libcurl than this. Stefan